Date: Mon, 08 Aug 2005 13:09:37 -0700 From: Julian Elischer <julian@elischer.org> To: Ed Maste <emaste@phaedrus.sandvine.ca> Cc: freebsd-net@freebsd.org Subject: Re: [PATCH] Minor cleanup of inline declaration for netgraph.h Message-ID: <42F7BC01.80102@elischer.org> In-Reply-To: <20050808194648.GB4843@sandvine.com> References: <20050808194648.GB4843@sandvine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ed Maste wrote:
> We build one of our netgraph modules with -W, which causes GCC
> to emit "warning: `inline' is not at beginning of declaration" for
> netgraph.h. It's pretty trivial, but the attached patch cleans this
> up so it's consistent across all of the functions in netgraph.h.
committed to -current.
Will MFC to other branches in 1 week if possible
>
> --
> Ed Maste, Sandvine Incorporated
>
>
> ------------------------------------------------------------------------
>
> Index: sys/netgraph/netgraph.h
> ===================================================================
> RCS file: /usr/cvs/src/sys/netgraph/netgraph.h,v
> retrieving revision 1.58
> diff -u -3 -r1.58 netgraph.h
> --- sys/netgraph/netgraph.h 2 Aug 2005 20:06:48 -0000 1.58
> +++ sys/netgraph/netgraph.h 8 Aug 2005 19:31:07 -0000
> @@ -175,7 +175,7 @@
> int line);
> static __inline void _ng_hook_force_queue(hook_p hook, char * file, int line);
>
> -static void __inline
> +static __inline void
> _chkhook(hook_p hook, char *file, int line)
> {
> if (hook->hk_magic != HK_MAGIC) {
> @@ -407,7 +407,7 @@
>
> #ifdef NETGRAPH_DEBUG /*----------------------------------------------*/
> void dumpnode(node_p node, char *file, int line);
> -static void __inline _chknode(node_p node, char *file, int line);
> +static __inline void _chknode(node_p node, char *file, int line);
> static __inline char * _ng_node_name(node_p node, char *file, int line);
> static __inline int _ng_node_has_name(node_p node, char *file, int line);
> static __inline ng_ID_t _ng_node_id(node_p node, char *file, int line);
> @@ -425,7 +425,7 @@
> ng_fn_eachhook *fn, void *arg, char *file, int line);
> static __inline void _ng_node_revive(node_p node, char *file, int line);
>
> -static void __inline
> +static __inline void
> _chknode(node_p node, char *file, int line)
> {
> if (node->nd_magic != ND_MAGIC) {
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42F7BC01.80102>