Date: Wed, 11 Oct 2023 12:04:14 +0530 From: Ravi Pokala <rpokala@freebsd.org> To: Alexander Motin <mav@FreeBSD.org>, Martin Matuska <mm@FreeBSD.org>, <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org> Subject: Re: 26103ccba8b7 - main - zfs: enable block cloning by default Message-ID: <71605D3D-27E5-484A-B432-CD18BB924E04@panasas.com> In-Reply-To: <c5bafe02-a52d-dbfb-4ae4-bfcf03b32ffb@FreeBSD.org> References: <202310102247.39AMlsjX018898@gitrepo.freebsd.org> <2D247230-D189-4A43-85A2-0F2442A9CA6A@panasas.com> <c5bafe02-a52d-dbfb-4ae4-bfcf03b32ffb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks for the explanation, Alexander. -Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: <owner-src-committers@freebsd.org <mailto:owner-src-committers@freebs= d.org>> on behalf of Alexander Motin <mav@FreeBSD.org <mailto:mav@FreeBSD.or= g>> Date: Wednesday, October 11, 2023 at 08:58 To: Ravi Pokala <rpokala@freebsd.org <mailto:rpokala@freebsd.org>>, Martin = Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org>>, <src-committers@FreeBSD.or= g <mailto:src-committers@FreeBSD.org>>, <dev-commits-src-all@FreeBSD.org <ma= ilto:dev-commits-src-all@FreeBSD.org>>, <dev-commits-src-main@FreeBSD.org <m= ailto:dev-commits-src-main@FreeBSD.org>> Subject: Re: 26103ccba8b7 - main - zfs: enable block cloning by default Hi Ravi, It was disabled because 6 months ago when it was introduced there were=20 some bug reports, and people preferred to stay away rather than debug=20 it. Since then Linux support was added with respective testing and=20 fixing. Several bugs found during FreeBSD testing were addressed, and=20 all the tests are passing clean now. In upstream OpenZFS this feature=20 was never actually disabled, and the release of OpenZFS 2.2.0 including=20 it should be officially tagged nearest days. So we feel it is time for=20 another try. At least until any other issues are reported, there is no=20 reason for it to stay disabled. On 10.10.2023 22:44, Ravi Pokala wrote: > Hi Martin, >=20 > The commit message says "what", not "why". >=20 > Why was block cloning disabled by default before, and why is it being ena= bled now? >=20 > Thanks, >=20 > Ravi (rpokala@) >=20 > =EF=BB=BF-----Original Message----- > From: <owner-src-committers@freebsd.org <mailto:owner-src-committers@free= bsd.org> <mailto:owner-src-committers@freebsd.org <mailto:owner-src-committe= rs@freebsd.org>>> on behalf of Martin Matuska <mm@FreeBSD.org <mailto:mm@Fre= eBSD.org> <mailto:mm@FreeBSD.org <mailto:mm@FreeBSD.org>>> > Date: Wednesday, October 11, 2023 at 04:17 > To: <src-committers@FreeBSD.org <mailto:src-committers@FreeBSD.org> <mail= to:src-committers@FreeBSD.org <mailto:src-committers@FreeBSD.org>>>, <dev-co= mmits-src-all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org> <mailto:d= ev-commits-src-all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>>, <= dev-commits-src-main@FreeBSD.org <mailto:dev-commits-src-main@FreeBSD.org> <= mailto:dev-commits-src-main@FreeBSD.org <mailto:dev-commits-src-main@FreeBSD= .org>>> > Subject: git: 26103ccba8b7 - main - zfs: enable block cloning by default >=20 >=20 > The branch main has been updated by mm: >=20 >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D26103ccba8b75038bd8377326852= 4ac814bfa334 <https://cgit.FreeBSD.org/src/commit/?id=3D26103ccba8b75038bd8377= 3268524ac814bfa334> <https://cgit.FreeBSD.org/src/commit/?id=3D26103ccba8b7503= 8bd83773268524ac814bfa334> <https://cgit.FreeBSD.org/src/commit/?id=3D26103ccb= a8b75038bd83773268524ac814bfa334>> >=20 >=20 > commit 26103ccba8b75038bd83773268524ac814bfa334 > Author: Martin Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org> <mailto:mm= @FreeBSD.org <mailto:mm@FreeBSD.org>>> > AuthorDate: 2023-10-10 22:43:35 +0000 > Commit: Martin Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org> <mailto:mm= @FreeBSD.org <mailto:mm@FreeBSD.org>>> > CommitDate: 2023-10-10 22:43:35 +0000 >=20 >=20 > zfs: enable block cloning by default >=20 >=20 > Discussed with: markj > Reviewed by: mav > Tested by: mm (FreeBSD test suite + OpenZFS test suite) > MFC after: 2 months > Differential Revision: https://reviews.freebsd.org/D41991 <https://review= s.freebsd.org/D41991> <https://reviews.freebsd.org/D41991>; <https://reviews.= freebsd.org/D41991>> > --- > sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 >=20 > diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c b/sys= /contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > index 8969fd6a54bd..09e18de81748 100644 > --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > @@ -89,7 +89,7 @@ int zfs_debug_level; > SYSCTL_INT(_vfs_zfs, OID_AUTO, debug, CTLFLAG_RWTUN, &zfs_debug_level, 0, > "Debug level"); >=20 >=20 > -int zfs_bclone_enabled; > +int zfs_bclone_enabled =3D 1; > SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, > &zfs_bclone_enabled, 0, "Enable block cloning"); >=20 >=20 >=20 >=20 >=20 >=20 --=20 Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?71605D3D-27E5-484A-B432-CD18BB924E04>