Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Apr 2024 08:05:40 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 3e1c8a35f741 - main - tcp: improve consistency
Message-ID:  <202404060805.43685e0u094888@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=3e1c8a35f741a5d114d0ba670b15191355711fe9

commit 3e1c8a35f741a5d114d0ba670b15191355711fe9
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2024-04-06 08:02:06 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2024-04-06 08:02:06 +0000

    tcp: improve consistency
    
    No functional change intended.
    
    Reported by:            Coverity Scan
    CID:                    1523781
    Reviewed by:            rscheff
    MFC after:              3 days
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D44645
---
 sys/netinet/tcp_input.c    | 2 +-
 sys/netinet/tcp_timewait.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index 8410cb490915..d27a79d1c3b1 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -1955,7 +1955,7 @@ tcp_do_segment(struct tcpcb *tp, struct mbuf *m, struct tcphdr *th,
 				tp->t_flags |= TF_DELACK;
 			} else {
 				tp->t_flags |= TF_ACKNOW;
-				tcp_output(tp);
+				(void) tcp_output(tp);
 			}
 			goto check_delack;
 		}
diff --git a/sys/netinet/tcp_timewait.c b/sys/netinet/tcp_timewait.c
index 266556274e18..8d77db275310 100644
--- a/sys/netinet/tcp_timewait.c
+++ b/sys/netinet/tcp_timewait.c
@@ -123,7 +123,7 @@ tcp_twstart(struct tcpcb *tp)
 	soisdisconnected(inp->inp_socket);
 
 	if (tp->t_flags & TF_ACKNOW)
-		tcp_output(tp);
+		(void) tcp_output(tp);
 
 	if (V_nolocaltimewait && (
 #ifdef INET6



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202404060805.43685e0u094888>