Date: Mon, 15 Feb 2021 21:58:45 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 252085] new port: editors/codelite-devel: powerful open-source, cross platform code editor for the C/C++ programming languages (development version) Message-ID: <bug-252085-7788-ZoK174ch6K@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-252085-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-252085-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252085 --- Comment #4 from daniel.engberg.lists@pyret.net --- Hi Ivan, Can we transfer this to the main port instead? It's soon going to be broken= due to bumping pango. A few things that can be improved by looking at your Makefile L4 and L26: Please follow Porter's Handbook=20 https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#m= akefile-master_sites-github-ex5 L12 Seems to be GPLv2 ? Define LICENSE_FILE https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#l= icenses-license_file-ex1 L17 Remove? L27 is already defined by the framework https://svnweb.freebsd.org/ports/head/Mk/Uses/cmake.mk?revision=3D488341&vi= ew=3Dmarkup#l68 L34 is this really needed and if it is, please use a proper DEBUG menu opti= on https://github.com/eranif/codelite/blob/master/CMakeLists.txt#L429 L105, are you really sure about that? There is quite a bit of REINPLACE_CMD going on, this is in general discoura= ged perhaps usage can be reduced and replaced with patches? Some things are out of order, have a look at portlint and/or portclippy Does it pass poudriere? Great work! Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-252085-7788-ZoK174ch6K>