Date: Sat, 5 Jun 2010 08:36:37 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r208819 - head/sys/cam/ata Message-ID: <201006050836.o558acgp066159@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mav Date: Sat Jun 5 08:36:37 2010 New Revision: 208819 URL: http://svn.freebsd.org/changeset/base/208819 Log: Fix double free on error. Found with: Coverity Prevent(tm) CID: 4573 Modified: head/sys/cam/ata/ata_pmp.c Modified: head/sys/cam/ata/ata_pmp.c ============================================================================== --- head/sys/cam/ata/ata_pmp.c Sat Jun 5 08:21:18 2010 (r208818) +++ head/sys/cam/ata/ata_pmp.c Sat Jun 5 08:36:37 2010 (r208819) @@ -737,10 +737,8 @@ pmpdone(struct cam_periph *periph, union if (xpt_create_path(&dpath, periph, xpt_path_path_id(periph->path), i, 0) != CAM_REQ_CMP) { - printf("pmpdone: xpt_create_path failed" - ", bus scan halted\n"); - xpt_free_ccb(done_ccb); - goto done; + printf("pmpdone: xpt_create_path failed\n"); + continue; } /* If we did hard reset to this device, inform XPT. */ if ((softc->reset & softc->found & (1 << i)) != 0)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006050836.o558acgp066159>