Date: Tue, 5 Nov 2013 16:45:19 +0100 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Dimitry Andric <dim@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r257691 - head/gnu/lib/libgcc Message-ID: <20131105154519.GD65141@onelab2.iet.unipi.it> In-Reply-To: <201311050737.rA57bZkq059529@svn.freebsd.org> References: <201311050737.rA57bZkq059529@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 05, 2013 at 07:37:35AM +0000, Dimitry Andric wrote: > Author: dim > Date: Tue Nov 5 07:37:35 2013 > New Revision: 257691 > URL: http://svnweb.freebsd.org/changeset/base/257691 > > Log: > Fix libgcc build with gcc after r257645, by using -Wno-static-in-inline > for clang only. thanks. I wonder if it is worthwhile adding to the default rules some compiler-specific CFLAGS, say CFLAGS_CLANG and CFLAGS_GCC (there is only a handful of cases now so maybe it is overkill, and it harms readability; on the other hand, the Makefiles already make a lot of assumptions on variable names) % find ../head -name Makefile -exec grep -H COMPILER_TYPE \{\} \; ../head/gnu/lib/libgcc/Makefile:.if ${COMPILER_TYPE} != "clang" || ${TARGET_CPUARCH} != "arm" ../head/gnu/lib/libgcc/Makefile:.if ${COMPILER_TYPE} == "clang" ../head/gnu/lib/libsupc++/Makefile:.if ${COMPILER_TYPE} == "clang" ../head/gnu/lib/libstdc++/Makefile:.if ${COMPILER_TYPE} == "clang" ../head/tools/tools/ath/athstats/Makefile:.if (${COMPILER_TYPE} == "clang") ../head/tools/tools/net80211/wlanstats/Makefile:.if ${COMPILER_TYPE} == "clang" cheers luigi > Modified: > head/gnu/lib/libgcc/Makefile > > Modified: head/gnu/lib/libgcc/Makefile > ============================================================================== > --- head/gnu/lib/libgcc/Makefile Tue Nov 5 07:36:17 2013 (r257690) > +++ head/gnu/lib/libgcc/Makefile Tue Nov 5 07:37:35 2013 (r257691) > @@ -36,7 +36,9 @@ CFLAGS+= -DIN_GCC -DIN_LIBGCC2 -D__GCC_F > # function with external linkage [-Wstatic-in-inline] > # gcc_assert (index < (int) sizeof(dwarf_reg_size_table)); > # ^ > +.if ${COMPILER_TYPE} == "clang" > CFLAGS+= -Wno-static-in-inline > +.endif > > LDFLAGS+= -nodefaultlibs > LDADD+= -lc
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131105154519.GD65141>