Date: Mon, 28 Nov 2022 09:17:05 -0800 From: Adrian Chadd <adrian@freebsd.org> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: freebsd-wireless@freebsd.org Subject: Re: IEEE80211_DEBUG_REFCNT breaks drivers Message-ID: <CAJ-VmokecVa2xNgqSbvfPfy2ezMvS1JC4Hm65Ej2n5OpwXkO4Q@mail.gmail.com> In-Reply-To: <rqo55p4p-964s-pqps-r482-oqo1on5q5spr@mnoonqbm.arg>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, 28 Nov 2022 at 08:15, Bjoern A. Zeeb <bz@freebsd.org> wrote: > Hi, > > adding IEEE80211_DEBUG_REFCNT to a kernel config breaks various wireless > driver builds as they do not include opt_wlan.h and thus get the other > incarnation of various functions (with different argument count) from > ieee80211_node.h . > Ugh. :-) Yeah, that whole binary ABI change thing sucks. Yeah, drivers should be including opt_wlan.h. I had a chat with warner about this years ago and IIRC the thought was that we shouldn't have /binary ABI/ changes because of opt_XXX.h flags that aren't global.. but I don't know how many people care about things at that level now? -adrian [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 28 Nov 2022 at 08:15, Bjoern A. Zeeb <<a href="mailto:bz@freebsd.org">bz@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br> <br> adding IEEE80211_DEBUG_REFCNT to a kernel config breaks various wireless<br> driver builds as they do not include opt_wlan.h and thus get the other<br> incarnation of various functions (with different argument count) from<br> ieee80211_node.h .<br></blockquote><div><br></div><div>Ugh. :-) Yeah, that whole binary ABI change thing sucks.</div><div><br></div><div>Yeah, drivers should be including opt_wlan.h. I had a chat with warner about this years ago and IIRC the thought was that we shouldn't have /binary ABI/ changes because of opt_XXX.h flags that aren't global.. but I don't know how many people care about things at that level now?</div><div><br></div><div><br></div><div><br></div><div>-adrian</div><div><br></div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokecVa2xNgqSbvfPfy2ezMvS1JC4Hm65Ej2n5OpwXkO4Q>