Date: Thu, 20 Jan 2005 15:10:31 GMT From: Ceri Davies <ceri@submonkey.net> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/76494: passwd does not indicate a successful change - causes problems with Samba password sync Message-ID: <200501201510.j0KFAVSv028920@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR misc/76494; it has been noted by GNATS. From: Ceri Davies <ceri@submonkey.net> To: Rob Mason <masonr@bsdbox.homeunix.com> Cc: Subject: Re: misc/76494: passwd does not indicate a successful change - causes problems with Samba password sync Date: Thu, 20 Jan 2005 15:05:45 +0000 On Thu, Jan 20, 2005 at 02:48:51PM +0000, Rob Mason wrote: > On Thu, Jan 20, 2005 at 10:17:50AM +0000, Ceri Davies wrote: > > On Thu, Jan 20, 2005 at 09:46:31AM +0000, Rob Mason wrote: > > > > > The passwd command on 4-STABLE output the text "passwd: done" when a > > > password was changed. This feature is used by the Samba-3 port to > > > indicate a successful change in the 'passwd chat' config option. > > > 5-STABLE does not indicate that the password change is successful > > > > What's wrong with a return status? > > Nothing from a functional point of view - however, this is not how the > 4-STABLE passwd command behaved. I believe that other programs (like > Samba) that are dependent upon core system utilities will break. This > will be a major source of frustration for many admins. Perhaps I should > have filed this PR under 'advocacy'? No, it's good where it is; it was just a question. > > > Apply the following patch: > > > > > > *** 157,164 **** > > > --- 157,165 ---- > > > /* set new password */ > > > pam_err = pam_chauthtok(pamh, 0); > > > pam_check("pam_chauthtok"); > > > > > > end: > > > + if (pam_err == PAM_SUCCESS) fprintf(stderr, "Password Changed\n"); > > > pam_end(pamh, pam_err); > > > exit(pam_err == PAM_SUCCESS ? 0 : 1); > > > } > > > > It also strikes me that this is not the same as the 4.X output; why? > > Apologies - my mistake. This is the incorrect output for 4-STABLE. OK, cool. Ceri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200501201510.j0KFAVSv028920>