Date: Thu, 4 Jun 2009 15:10:29 +0000 (UTC) From: Konstantin Belousov <kib@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/kern kern_descrip.c Message-ID: <200906041510.n54FAjTU092214@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
kib 2009-06-04 15:10:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_descrip.c Log: SVN rev 193438 on 2009-06-04 15:10:29Z by kib MFC r192094: Do not advance req->oldidx when sysctl_old_user returning an error due to copyout failure or short buffer. MFC r192144: Revert r192094. The revision caused problems for sysctl(3) consumers that expect that oldlen is filled with required buffer length even when supplied buffer is too short and returned error is ENOMEM. Redo the fix for kern.proc.filedesc, by reverting the req->oldidx when remaining buffer space is too short for the current kinfo_file structure. Also, only ignore ENOMEM. We have to convert ENOMEM to no error condition to keep existing interface for the sysctl, though. Revision Changes Path 1.313.2.18 +15 -2 src/sys/kern/kern_descrip.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906041510.n54FAjTU092214>