Date: Wed, 22 Oct 2014 01:03:40 +0400 From: Slawa Olhovchenkov <slw@zxy.spb.ru> To: Mateusz Guzik <mjg@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r273335 - head/sys/fs/unionfs Message-ID: <20141021210340.GA2178@zxy.spb.ru> In-Reply-To: <201410201753.s9KHrnaG009500@svn.freebsd.org> References: <201410201753.s9KHrnaG009500@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 20, 2014 at 05:53:49PM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Mon Oct 20 17:53:49 2014 > New Revision: 273335 > URL: https://svnweb.freebsd.org/changeset/base/273335 > > Log: > unionfs: hold mount interlock while manipulating mnt_flag > > This is for consistency with other filesystems. Can you check interoperability unionfs with zfs and devfs? I have crashed unionfs with zfs. unionfs with devfs need double devfs mount. > Modified: > head/sys/fs/unionfs/union_vfsops.c > > Modified: head/sys/fs/unionfs/union_vfsops.c > ============================================================================== > --- head/sys/fs/unionfs/union_vfsops.c Mon Oct 20 17:04:03 2014 (r273334) > +++ head/sys/fs/unionfs/union_vfsops.c Mon Oct 20 17:53:49 2014 (r273335) > @@ -290,12 +290,14 @@ unionfs_domount(struct mount *mp) > return (error); > } > > + MNT_ILOCK(mp); > /* > * Check mnt_flag > */ > if ((ump->um_lowervp->v_mount->mnt_flag & MNT_LOCAL) && > (ump->um_uppervp->v_mount->mnt_flag & MNT_LOCAL)) > mp->mnt_flag |= MNT_LOCAL; > + MNT_IUNLOCK(mp); > > /* > * Get new fsid > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141021210340.GA2178>