Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Jun 2025 06:22:33 GMT
From:      Lexi Winter <ivy@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: d9b6b10e5ebb - main - if_vlan_var.h: fix value of DOT1Q_VID_MAX
Message-ID:  <202506040622.5546MXKD031980@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by ivy:

URL: https://cgit.FreeBSD.org/src/commit/?id=d9b6b10e5ebbb517a079e89ac0de99be3b815c8d

commit d9b6b10e5ebbb517a079e89ac0de99be3b815c8d
Author:     Lexi Winter <ivy@FreeBSD.org>
AuthorDate: 2025-06-04 05:33:05 +0000
Commit:     Lexi Winter <ivy@FreeBSD.org>
CommitDate: 2025-06-04 05:33:57 +0000

    if_vlan_var.h: fix value of DOT1Q_VID_MAX
    
    This should be 4094 (0xFFE), not 4095 (0xFFF), since 0xFFF is not a
    valid VID.
    
    Fixes:  c59492025073 ("sys/net: add DOT1Q_VID_{MIN,MAX}")
    MFC after:      3 days
    Reviewed by:    kevans, kp, adrian
    Approved by:    kevans (mentor)
    Differential Revision:  https://reviews.freebsd.org/D50576
---
 sys/net/if_vlan_var.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/net/if_vlan_var.h b/sys/net/if_vlan_var.h
index e7171974289b..3a8e45dfab03 100644
--- a/sys/net/if_vlan_var.h
+++ b/sys/net/if_vlan_var.h
@@ -131,7 +131,7 @@ struct	vlanreq {
 #define	DOT1Q_VID_DEF_SR_PVID	0x2
 #define	DOT1Q_VID_RSVD_IMPL	0xfff
 #define	DOT1Q_VID_MIN		1	/* minimum valid vlan id */
-#define	DOT1Q_VID_MAX		4095	/* maximum valid vlan id */
+#define	DOT1Q_VID_MAX		4094	/* maximum valid vlan id */
 
 /*
  * 802.1q full tag. Proto and vid are stored in host byte order.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506040622.5546MXKD031980>