Date: Wed, 31 May 2000 11:12:04 -0700 From: Mike Smith <msmith@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: Mike Smith <msmith@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/quot quot.c Message-ID: <200005311812.LAA00398@mass.cdrom.com> In-Reply-To: Your message of "Thu, 01 Jun 2000 03:23:10 %2B1000." <Pine.BSF.4.21.0006010307460.744-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > 8) This sounds like an argument for sysctlbyname("path_dev") to me...
>
> I only meant complete hard-coding of the strings. If everything used
> macros for paths, then it might be possible to support dynamic paths by
> #defining the macros as function calls.
>
> > How do you feel about ANSI string concatenation, eg:
> >
> > open(PATH_DEV "rmt0", ...
>
> This would break K&R support :-), and wouldn't work in most contexts
> (the basename is normally from argv[]; for dump(8) it may be from the
> environment).
In the cases where path components are separate, there's no issue (since
the code typically uses sprintf or strcat or similar); the only case that
gives me pause is when we have something like: "/dev/rmt0"
If all that we lose is K&R support, I'm not going to shed any tears.
Sorry. 8)
--
\\ Give a man a fish, and you feed him for a day. \\ Mike Smith
\\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org
\\ and he'll hate you for a lifetime. \\ msmith@cdrom.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005311812.LAA00398>