Date: Sat, 18 Jan 2003 18:41:11 +0100 (CET) From: Joost Bekkers <joost@bps.jodocus.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: misc/47191: 'make iso.1' in /usr/src/release: iso's are not bootable Message-ID: <200301181741.h0IHfBT78680@bps.jodocus.org>
next in thread | raw e-mail | index | archive | help
>Number: 47191
>Category: misc
>Synopsis: 'make iso.1' in /usr/src/release: iso's are not bootable
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jan 18 09:50:02 PST 2003
>Closed-Date:
>Last-Modified:
>Originator: Joost Bekkers
>Release: FreeBSD 4.5-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD bps.jodocus.org 4.5-RELEASE-p2 FreeBSD 4.5-RELEASE-p2 #1: Wed Aug 7 10:13:09 CEST 2002 joost@bps.jodocus.org:/usr/src/sys/compile/bps i386
>Description:
When you do a 'make iso.1' in /usr/src/release of the chroot-ed environment created
by make release. The iso images it creates are only bootable if you define MAKE_ISOS.
This doesn't seem right to me, because you shouldn't need to tell it twice to make iso's.
(ie 'make iso.1 -DMAKE_ISOS')
>How-To-Repeat:
start a 'make release' and "forget" to include -DMAKE_ISOS
chroot /usr/release (or whatever)
cd /usr/src/release
make iso.1
>Fix:
***************
*** 234,242 ****
EXTRAS= cdrom.1 ftp.1
.if defined(MAKE_ISOS)
EXTRAS+= iso.1
.if ${TARGET} != "pc98"
BOOTABLE="-b"
- .endif
.endif
.if !defined(NODOC)
--- 234,244 ----
EXTRAS= cdrom.1 ftp.1
.if defined(MAKE_ISOS)
EXTRAS+= iso.1
+ .endif
+ #moved out of previous .if to make the iso.1 target work properly when
+ #not 'called' through release
.if ${TARGET} != "pc98"
BOOTABLE="-b"
.endif
.if !defined(NODOC)
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301181741.h0IHfBT78680>