Date: Wed, 8 Dec 2010 10:24:02 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Martin Matuska <mm@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216291 - head/cddl/contrib/opensolaris/lib/libzfs/common Message-ID: <20101208092402.GC1692@garage.freebsd.pl> In-Reply-To: <4CFF4C65.4030607@FreeBSD.org> References: <201012080857.oB88vbH6096250@svn.freebsd.org> <20101208090433.GB1692@garage.freebsd.pl> <4CFF4C65.4030607@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--RIYY1s2vRbPFwWeW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 08, 2010 at 10:14:13AM +0100, Martin Matuska wrote: > Here are some arguments: >=20 > a) it was removed in OpenSolaris rev. 12865:08987220809a > b) a root pool does not not have to be a boot pool >=20 > So if we need a warning here, it should print only some general > suggestion because > user may attach any vdev (e.g. a file or a memory disk) to make a mirror > from a root pool. > And as this was removed upstream the warning should be put into perforce > as well. Hmm, I think I saw this warning on more recent ZFS. All in all we currently print this when we upgrade root pool we print the following: If you boot from pool 'foo', don't forget to update boot code. Assuming you use GPT partitioning and da0 is your boot disk the following command will do it: gpart bootcode -b /boot/pmbr -p /boot/gptzfsboot -i 1 da0 (Note, that bootfs property doesn't have to be set to boot from a pool.) We should print similar information when: - We set bootfs property. - Add new vdev(s) to root pool. - Attach new vdev(s) to root pool. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --RIYY1s2vRbPFwWeW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkz/TrIACgkQForvXbEpPzQVswCfSm4zSNXnJtB0VncSQk9H9DNc HkwAn35XzoBm4ensov/grw4zAynD4Prx =QbW5 -----END PGP SIGNATURE----- --RIYY1s2vRbPFwWeW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101208092402.GC1692>