Date: Mon, 22 May 1995 12:33:08 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: adam@veda.is (Adam David) Cc: adam@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-gnu@freefall.cdrom.com Subject: Re: cvs commit: src/gnu/lib/libreadline display.c Message-ID: <199505221933.MAA05512@gndrsh.aac.dev.com> In-Reply-To: <199505221924.TAA09678@veda.is> from "Adam David" at May 22, 95 07:24:30 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > > > Modified: gnu/lib/libreadline display.c > > > Log: > > > eliminate coredump for readline(NULL) case > > > > Did I miss a message about code freeze being lifted??? > > Bugfix only, as explicitly permitted by freefall's motd. There was a full page message sent to -committers describing in detail on how thing are to be done. Changes in any form to libraries is a reviewable change. > > A library is defanitly a critical place to be patching. > > There is no change of interface, only an advertised functionality > that dumped core instead of the expected behaviour. Change is change, any and every change *can* cause a new bug, the posted process did not say anything about interface changes or not, it said critical system components, and a library is defanitly a critical system component. > > Reviewd by: ?????? > > Is this necessary for a trivial bugfix? YES! No mater how trivial it may look, it can cause a problem if not carefully looked at. I have seen some of the most trivial bug fixes break tons of things due to an oversight. > old: strlen(local_prompt) > new: local_prompt ? strlen(local_prompt) : 0 > > local_prompt == NULL is a valid state, as empty prompts may be represented > as either "" or NULL in the rest of the code. The above is pretty useless, how about a context diff??? -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199505221933.MAA05512>