Date: Thu, 5 May 2005 20:52:39 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Xin LI <delphij@frontfree.net> Cc: current@FreeBSD.org Subject: Re: [current tinderbox] failure on amd64/amd64 Message-ID: <20050505204235.L7880@delplex.bde.org> In-Reply-To: <20050505090907.GA41071@frontfree.net> References: <20050505084428.A12D07306E@freebsd-current.sentex.ca> <20050505090907.GA41071@frontfree.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 5 May 2005, Xin LI wrote: > On Thu, May 05, 2005 at 04:44:28AM -0400, FreeBSD Tinderbox wrote: >> /tinderbox/CURRENT/amd64/amd64/src/sys/modules/ndis/../../compat/ndis/subr_ndis.c: In function `NdisMFreeSharedMemory': >> /tinderbox/CURRENT/amd64/amd64/src/sys/modules/ndis/../../compat/ndis/subr_ndis.c:1710: warning: long long unsigned int format, uint64_t arg (arg 3) > > Maybe we should make use of the PRIx64 macro? (see patch attached) No. PRI* is a bug in C99; it should never be used. Just cast the arg to a suitable larger type with a known format (uintmax_t here). (C99 is missing support for better ways; either %I as in sfio (?) or %DWIM where the compiler rewrites the string to match the arg would be better.) Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050505204235.L7880>