Date: Tue, 2 Aug 2016 16:54:59 +0200 From: Guido Falsi <mad@madpilot.net> To: Alexey Dokuchaev <danfe@FreeBSD.org>, "Pedro F. Giffuni" <pfg@FreeBSD.org> Cc: svn-src-head@freebsd.org, Mikhail Teterin <mi@FreeBSD.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r303047 - head/usr.bin/sed Message-ID: <51d8013e-bc4b-a511-306d-0e362a8c3e86@madpilot.net> In-Reply-To: <20160802141738.GA84154@FreeBSD.org> References: <201607192256.u6JMuewv007503@repo.freebsd.org> <20160802141738.GA84154@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/02/16 16:17, Alexey Dokuchaev wrote: > On Tue, Jul 19, 2016 at 10:56:40PM +0000, Pedro F. Giffuni wrote: >> New Revision: 303047 >> URL: https://svnweb.freebsd.org/changeset/base/303047 >> >> Log: >> sed(1): Assorted cleanups and simplifications. >> >> Const-ify several variables, make it build cleanly with WARNS level 5. >> >> Submitted by: mi >> PR: 195929 >> MFC after: 1 month > > Hi Pedro, > > This change causes `games/openttd' to fail now, because the generated > `$wrkdir/openttd-1.6.1/objs/release/Makefile' file is broken (SRCS var > is set to bogus value, search for ^SRCS). Reverting usr.bin/sed back > to r303046 fixes it. > > The latest revision (with ngie@'s fix) exhibits the same problem. > > Now the port uses somewhat obscure build system, but the sed(1) magic > happens inside generate_foo() functions using SRC_REPLACE variable set > in make_sed() inside `config.lib' file; these functions are called by > the configure script. > > Would you or Mikhail mind taking a look? Thanks, By chance I had a look at this, thinking it was a local problem on my machine, and noticed that the substitutions get truncated at exactly 5120 characters. Looks like some hardcoded 5KiB buffer. -- Guido Falsi <mad@madpilot.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51d8013e-bc4b-a511-306d-0e362a8c3e86>