Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Aug 2025 09:08:47 -0400
From:      TIM Beach <timothyk@beachpatt.com>
To:        Michael Grimm <trashcan@ellael.org>
Cc:        freebsd-current@freebsd.org
Subject:   Re: Console keyboard disabled under Parallels
Message-ID:  <a608b2ec-bf32-4657-a8a9-660d1f084e04@beachpatt.com>
In-Reply-To: <C7780B81-BC43-49DB-A1D3-C8B9220B59BB@ellael.org>
References:  <a77ad4b2-49c5-4cf0-835b-b16bc869ec0e@beachpatt.com> <C7780B81-BC43-49DB-A1D3-C8B9220B59BB@ellael.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On 8/21/25 4:28 PM, Michael Grimm wrote:
> TIM Beach<timothyk@beachpatt.com> wrote:
>
>> When using Current under Parallels Desktop Pro, recent kernels remove the keyboard function from the default console.
> […]
>
>> Was there a change to usbhid or ugen when CURRENT went to PRERELEASE?
> Please have a look at:https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288968
>
> There's a patch that needs to be tested by someone running Parallels.
>
> Regards,
> Michael
>
Thank you, I was going to post this as a Comment in the bug report, but 
my login isn't working and I'm pressed for time this morning.

Reporting it here for historical purposes in case anyone else runs into 
it.  The code in Comment 6 in the bug report fixed the issue.


Using this diff on current sources updated 12 pm UTC today and 
rebuilding/installing the kernel, fixed the problem:

# diff -u /usr/src/sys/dev/hid/hkbd.c.orig /usr/src/sys/dev/hid/hkbd.c
--- /usr/src/sys/dev/hid/hkbd.c.orig	2025-08-20 11:09:37.000000000 -0700
+++ /usr/src/sys/dev/hid/hkbd.c	2025-08-21 14:32:06.870020000 -0700
@@ -1596,8 +1596,9 @@
  		sc->sc_state &= ~LOCK_MASK;
  		sc->sc_state |= *(int *)arg;
  
-		/* set LEDs and quit */
-		return (hkbd_ioctl_locked(kbd, KDSETLED, arg));
+		/* try to set LEDs and quit */
+		(void)hkbd_ioctl_locked(kbd, KDSETLED, arg);
+		return (0);
  

Thanks again,

Tim


[-- Attachment #2 --]
<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 8/21/25 4:28 PM, Michael Grimm
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:C7780B81-BC43-49DB-A1D3-C8B9220B59BB@ellael.org">
      <pre wrap="" class="moz-quote-pre">TIM Beach <a class="moz-txt-link-rfc2396E" href="mailto:timothyk@beachpatt.com">&lt;timothyk@beachpatt.com&gt;</a> wrote:

</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">When using Current under Parallels Desktop Pro, recent kernels remove the keyboard function from the default console.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
[…]

</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">Was there a change to usbhid or ugen when CURRENT went to PRERELEASE?
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
Please have a look at: <a class="moz-txt-link-freetext" href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288968">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288968</a>;

There's a patch that needs to be tested by someone running Parallels.

Regards,
Michael

</pre>
    </blockquote>
    <p>Thank you, I was going to post this as a Comment in the bug
      report, but my login isn't working and I'm pressed for time this
      morning.</p>
    <p>Reporting it here for historical purposes in case anyone else
      runs into it.  The code in Comment 6 in the bug report fixed the
      issue.</p>
    <p><br>
    </p>
    <p>Using this diff on current sources updated 12 pm UTC today and
      rebuilding/installing the kernel, fixed the problem:</p>
    <pre class="bz_comment_text"
style="font-size: medium; font-family: monospace; white-space: pre-wrap; width: 50em; padding-left: 0.5em; padding-right: 0.5em; caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"># diff -u /usr/src/sys/dev/hid/hkbd.c.orig /usr/src/sys/dev/hid/hkbd.c
--- /usr/src/sys/dev/hid/hkbd.c.orig	2025-08-20 11:09:37.000000000 -0700
+++ /usr/src/sys/dev/hid/hkbd.c	2025-08-21 14:32:06.870020000 -0700
@@ -1596,8 +1596,9 @@
 		sc-&gt;sc_state &amp;= ~LOCK_MASK;
 		sc-&gt;sc_state |= *(int *)arg;
 
-		/* set LEDs and quit */
-		return (hkbd_ioctl_locked(kbd, KDSETLED, arg));
+		/* try to set LEDs and quit */
+		(void)hkbd_ioctl_locked(kbd, KDSETLED, arg);
+		return (0);
 

Thanks again,

Tim</pre>
    <p><br>
    </p>
  </body>
</html>
help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a608b2ec-bf32-4657-a8a9-660d1f084e04>