Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Mar 2021 10:27:33 GMT
From:      Alex Richardson <arichardson@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: ab0e7589d26b - stable/13 - readelf: Fix printing NT_FREEBSD_ARCH_TAG
Message-ID:  <202103171027.12HARXCI095868@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by arichardson:

URL: https://cgit.FreeBSD.org/src/commit/?id=ab0e7589d26b0d85e0b79360c5a84d4640840936

commit ab0e7589d26b0d85e0b79360c5a84d4640840936
Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: 2021-02-03 15:24:28 +0000
Commit:     Alex Richardson <arichardson@FreeBSD.org>
CommitDate: 2021-03-17 09:51:39 +0000

    readelf: Fix printing NT_FREEBSD_ARCH_TAG
    
    Looking at lib/csu/arm/crt1_s.S, this should be a string and therefore the
    restriction to 4 characters seems wrong.
    Found whle updating https://reviews.llvm.org/D74393.
    
    Reviewed By:    emaste
    Differential Revision: https://reviews.freebsd.org/D28470
    
    (cherry picked from commit 2a39919364b5368e026f656ff41861a3fdd56110)
---
 contrib/elftoolchain/readelf/readelf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/contrib/elftoolchain/readelf/readelf.c b/contrib/elftoolchain/readelf/readelf.c
index ff2fe8e7245f..022c9e9066ab 100644
--- a/contrib/elftoolchain/readelf/readelf.c
+++ b/contrib/elftoolchain/readelf/readelf.c
@@ -3748,9 +3748,7 @@ dump_notes_data(struct readelf *re, const char *name, uint32_t type,
 			return;
 		/* NT_FREEBSD_NOINIT_TAG carries no data, treat as unknown. */
 		case NT_FREEBSD_ARCH_TAG:
-			if (sz != 4)
-				goto unknown;
-			printf("   Arch tag: %x\n", ubuf[0]);
+			printf("   Arch tag: %s\n", buf);
 			return;
 		case NT_FREEBSD_FEATURE_CTL:
 			if (sz != 4)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202103171027.12HARXCI095868>