Date: Thu, 20 Oct 2005 17:24:15 +0200 From: Bradley T Hughes <bhughes@trolltech.com> To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/87729: most calls to malloc(3) generate warnings in valgrind Message-ID: <4357B69F.7050108@trolltech.com> In-Reply-To: <200510201520.j9KFKIZQ029076@freefall.freebsd.org> References: <200510201520.j9KFKIZQ029076@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------070208000107050800030908 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit FreeBSD-gnats-submit@FreeBSD.org wrote: > Thank you very much for your problem report. > It has the internal identification `bin/87729'. > The individual assigned to look at your > report is: freebsd-bugs. > > You can access the state of your problem report at any time > via this link: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=87729 > > >>Category: bin >>Responsible: freebsd-bugs >>Synopsis: most calls to malloc(3) generate warnings in valgrind >>Arrival-Date: Thu Oct 20 15:20:18 GMT 2005 Here is the patch that I couldn't attach when using the web form. -- Bradley T. Hughes - bhughes at trolltech.com Trolltech AS - Waldemar Thranes gt. 98 N-0175 Oslo, Norway --------------070208000107050800030908 Content-Type: text/plain; name="malloc.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="malloc.c.diff" --- malloc.c Wed Oct 19 13:30:01 2005 +++ malloc.c~ Wed Oct 19 13:29:01 2005 @@ -635,8 +635,11 @@ for(;k-i >= MALLOC_BITS; i += MALLOC_BITS) bp->bits[i / MALLOC_BITS] = ~0; - for(; i < k; i++) - bp->bits[i/MALLOC_BITS] |= 1<<(i%MALLOC_BITS); + if (i < k) { + bp->bits[i/MALLOC_BITS] = 0; + for(; i < k; i++) + bp->bits[i/MALLOC_BITS] |= 1<<(i%MALLOC_BITS); + } if (bp == bp->page) { /* Mark the ones we stole for ourselves */ --------------070208000107050800030908--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4357B69F.7050108>