Date: Tue, 10 Apr 2001 16:22:35 -0700 From: Kirk McKusick <mckusick@mckusick.com> To: Brian Somers <brian@Awfulhak.org> Cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps ps.c Message-ID: <200104102322.QAA41663@beastie.mckusick.com> In-Reply-To: Your message of "Sat, 07 Apr 2001 12:01:56 BST." <200104071101.f37B1ul55453@hak.lan.Awfulhak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In general, I removed the fields that were pointers as they
seemed rather useless to me on output. If there is a constituency
out there that finds looking at kernel addresses to be useful,
I have no objection to them being added back (provided that it
is done in a way that follows the rules so that it does not
break ps and friends).
Kirk McKusick
=-=-=-=-=-=
To: Dima Dorfman <dima@unixfreak.org>, mckusick@FreeBSD.org
Cc: Bruce Evans <bde@zeta.org.au>, Brian Somers <brian@FreeBSD.org>,
cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/bin/ps ps.c
In-Reply-To: Message from Dima Dorfman <dima@unixfreak.org>
of "Sat, 07 Apr 2001 01:04:12 PDT." <20010407080412.E21673E09@bazooka.unixfreak.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 07 Apr 2001 12:01:56 +0100
From: Brian Somers <brian@Awfulhak.org>
> Bruce Evans <bde@zeta.org.au> writes:
> > On Fri, 6 Apr 2001, Brian Somers wrote:
> > > Log:
> > > The sess column went away last December with v1.26 of keyword.c
> > > Remove it from ``jfmt''.
> > >
> > > Forgotten by: mckusick
> >
> > This stomps on PR 26057, which contains more complete fixes. It's
> > not clear whether the bug is the non-removal of the sess column and
> > the sess keyword or the removal of the e_sess pointer.
>
> This particular commit doesn't really hurt anything. We just need to
> decide whether there should be an e_sess (or ki_sess, now) pointer or
> not. PR 26057, which you mention, contains a patch to add it back.
> Although mckusick did explicitly say he was removing it in his
> kproc_info commit, he didn't provide rationale.
>
> So, the question is: do we want a `sess' column?
Personally I preferred it *with* the sess column (my change just
removed an irritating error message - I use ``ps j'' all the time and
have eventually gotten sick of seeing it). Kirk, do you have any
objections to restoring sess ?
> Regards,
>
> Dima Dorfman
> dima@unixfreak.org
Cheers.
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104102322.QAA41663>