Date: Tue, 9 Apr 2019 11:37:13 -0600 From: Warner Losh <imp@bsdimp.com> To: Rebecca Cran <rebecca@bluestop.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r346039 - head/sys/conf Message-ID: <CANCZdfoW90cQqRbTW1r%2Bz1d0s4%2BX2z9iaHseMoNMpKMUk8%2BAuA@mail.gmail.com> In-Reply-To: <c8880833-5a0e-c05c-1b3c-c6b027fed42c@bluestop.org> References: <201904081825.x38IPEpV054311@repo.freebsd.org> <c8880833-5a0e-c05c-1b3c-c6b027fed42c@bluestop.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 9, 2019 at 11:19 AM Rebecca Cran <rebecca@bluestop.org> wrote: > On 2019-04-08 12:25, Warner Losh wrote: > > Author: imp > > Date: Mon Apr 8 18:25:14 2019 > > New Revision: 346039 > > URL: https://svnweb.freebsd.org/changeset/base/346039 > > > > Log: > > Style only change: Prefer $() to `` > > > > $() is more modern and also nests. Convert the mix of styles to using > > only the former (although the latter was more common). It's the more > > dominant style in other shell scripts these days as well. > > > > Differential Revision: https://reviews.freebsd.org/D19840 > > > > Modified: > > head/sys/conf/newvers.sh > > > > Modified: head/sys/conf/newvers.sh > > > I thought I saw an email a few weeks ago that suggested that the list of > people who reviewed the patch should be copied into a "Reviewed by:" > line, to avoid only having that information in Phabricator. > > Am I remembering correctly, or is just mentioning the Phab review > considered sufficient? > You remember correctly. Sadly, there's no automation to make it happen, so it's easy to forget. I hate the notion that came out of the last discussion, but am trying to do it, but since there's no automation, I'll fail to do the right thing more often than not. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoW90cQqRbTW1r%2Bz1d0s4%2BX2z9iaHseMoNMpKMUk8%2BAuA>