Date: Fri, 30 Dec 2016 22:00:07 +0100 From: "O. Hartmann" <ohartmann@walstatt.org> To: Toomas Soome <tsoome@me.com> Cc: Dimitry Andric <dim@FreeBSD.org>, "O. Hartmann" <ohartmann@walstatt.org>, FreeBSD CURRENT <freebsd-current@freebsd.org>, Toomas Soome <tsoome@FreeBSD.org> Subject: Re: r 310850: buildworld failure due to: nandfs.c:1049:15: error: too many arguments to function call, Message-ID: <20161230220007.517c6586@thor.walstatt.dynvpn.de> In-Reply-To: <F2CCA263-F1A7-410A-902D-3AEC4A23E9A7@me.com> References: <20161230202338.73e7d00b@thor.walstatt.dynvpn.de> <30C71053-94F3-44D1-9089-CE31E67912DF@FreeBSD.org> <F2CCA263-F1A7-410A-902D-3AEC4A23E9A7@me.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/eJ279oHP8hIxcOSXE4.DoHp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am Fri, 30 Dec 2016 21:40:27 +0200 Toomas Soome <tsoome@me.com> schrieb: > > On 30. dets 2016, at 21:35, Dimitry Andric <dim@FreeBSD.org> wrote: > >=20 > > On 30 Dec 2016, at 20:23, O. Hartmann <ohartmann@walstatt.org> wrote: = =20 > >>=20 > >> Recent update of CURRENT to 2310850 fails with buildworld error: > >>=20 > >> [...] =20 > >> =3D=3D=3D> lib/atf/libatf-c++ (all) =20 > >> --- all_subdir_lib/libstand --- > >> --- nandfs.o --- > >> /usr/src/lib/libstand/nandfs.c:1049:15: error: too many arguments to f= unction call, > >> expected 6, have 7 buffer, NULL); > >> ^~~~ > >> /usr/obj/usr/src/tmp/usr/include/sys/_null.h:32:14: note: expanded fro= m macro 'NULL' > >> #define NULL ((void *)0) > >> ^~~~~~~~~~~ > >> 1 error generated. > >> *** [nandfs.o] Error code 1 =20 > >=20 > > This looks like the culprit to me: > >=20 > > On 30 Dec 2016, at 20:06, Toomas Soome <tsoome@FreeBSD.org> wrote: =20 > >> Author: tsoome > >> Date: Fri Dec 30 19:06:29 2016 > >> New Revision: 310850 > >> URL: https://svnweb.freebsd.org/changeset/base/310850 > >>=20 > >> Log: > >> dosfs support in libstand is broken since r298230 > >>=20 > >> Apparently the libstand dosfs optimization is a bit too optimistic > >> and did introduce possible memory corruption. > >>=20 > >> This patch is backing out the bad part and since this results in > >> dosfs reading full blocks now, we can also remove extra offset argument > >> from dv_strategy callback. > >>=20 > >> The analysis of the issue and the backout patch is provided by Mikhail= Kupchik. > >>=20 > >> PR: 214423 > >> Submitted by: Mikhail Kupchik > >> Reported by: Mikhail Kupchik > >> Reviewed by: bapt, allanjude > >> Approved by: allanjude (mentor) > >> MFC after: 1 month > >> Differential Revision: https://reviews.freebsd.org/D864 =20 > >=20 > > For some reason, your build seems to pick up an older stand.h header? > >=20 > > -Dimitry > > =20 >=20 >=20 > oh, apparently I *still* did miss one strategy call in nandfs.. Sorry, I= =E2=80=99ll try to fix > it asap. >=20 > rgds, > toomas That has been fixed, thanks. But another bug in CARP makes buildkernel failing ... --=20 O. Hartmann Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Abs.= 4 BDSG). --Sig_/eJ279oHP8hIxcOSXE4.DoHp Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iLUEARMKAB0WIQQZVZMzAtwC2T/86TrS528fyFhYlAUCWGbK2AAKCRDS528fyFhY lC6zAgCemxE4iN3NOBtxj80aJ1QqKJYKWgHbCcHYyqgF9qryW1CA1ecwli+INTTi uTMw2Yw8bFRVMEh5YoOPf9y/TACTAgCmVY6+v8QabJ6JSaf/6O4DPtURDiK/JZ2p 6aoSW8+NiijmuBd5zxCWDhZ/b1twnasM7vH8WSIasgYa77niy43g =MsLd -----END PGP SIGNATURE----- --Sig_/eJ279oHP8hIxcOSXE4.DoHp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161230220007.517c6586>