Date: Wed, 19 Aug 2015 11:45:45 +0000 (UTC) From: Zbigniew Bodek <zbb@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r286920 - head/sys/arm64/arm64 Message-ID: <201508191145.t7JBjjCv003471@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: zbb Date: Wed Aug 19 11:45:45 2015 New Revision: 286920 URL: https://svnweb.freebsd.org/changeset/base/286920 Log: Remove redundant mp_naps from ARM64 secondary CPU start-up code The global variable has been only used for CPU startup ordering which is not needed anyway. Obtained from: Semihalf Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D3296 Modified: head/sys/arm64/arm64/mp_machdep.c Modified: head/sys/arm64/arm64/mp_machdep.c ============================================================================== --- head/sys/arm64/arm64/mp_machdep.c Wed Aug 19 10:36:36 2015 (r286919) +++ head/sys/arm64/arm64/mp_machdep.c Wed Aug 19 11:45:45 2015 (r286920) @@ -94,8 +94,6 @@ void init_secondary(uint64_t); uint8_t secondary_stacks[MAXCPU - 1][PAGE_SIZE * KSTACK_PAGES] __aligned(16); -/* # of Applications processors */ -volatile int mp_naps; /* Set to 1 once we're ready to let the APs out of the pen. */ volatile int aps_ready = 0; @@ -211,16 +209,6 @@ init_secondary(uint64_t cpu) "mov x18, %0 \n" "msr tpidr_el1, %0" :: "r"(pcpup)); - /* - * pcpu_init() updates queue, so it should not be executed in parallel - * on several cores - */ - while(mp_naps < (cpu - 1)) - ; - - /* Signal our startup to BSP */ - atomic_add_rel_32(&mp_naps, 1); - /* Spin until the BSP releases the APs */ while (!aps_ready) __asm __volatile("wfe");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201508191145.t7JBjjCv003471>