Date: Mon, 14 Feb 2022 13:08:23 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 98b88b839df1 - main - x11/cde: actually fix build on powerpc64le Message-ID: <YgpGN7DrPLmvUWVm@KGPE-D16> In-Reply-To: <4k51-slp1-wny@FreeBSD.org> References: <202202141141.21EBfLVh090770@gitrepo.freebsd.org> <4k51-slp1-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--yotjpMnqJyoIoG2Y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 22-02-14 12:59:38, Jan Beich wrote: > Piotr Kubaj <pkubaj@FreeBSD.org> writes: >=20 > > The branch main has been updated by pkubaj: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D98b88b839df1a88f538b8b= fdc74e9734b0df7ea3 > > > > commit 98b88b839df1a88f538b8bfdc74e9734b0df7ea3 > > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > > AuthorDate: 2022-02-14 11:38:50 +0000 > > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > > CommitDate: 2022-02-14 11:38:50 +0000 > > > > x11/cde: actually fix build on powerpc64le > > =20 > > This port doesn't respect setting FLAGS via Makefile, so -DPOWERPC6= 4LE goes unnoticed. > > =20 > > Switch to ifdef __powerpc64__. > [...] > > -.if ${ARCH} =3D=3D powerpc64le > > -CPPFLAGS+=3D -DPOWERPC64LE > > -.endif > [...] > > -+#ifdef POWERPC64LE > > ++#ifdef __powerpc64__ > > + tmpval =3D va_listval(va_arg(ap, va_listarg)); > > + va_copy(ap, tmpval); > > +#else > > + va_copy(ap, va_listval(va_arg(ap, va_listarg))); > > +#endif >=20 > Do you intentionally ignore endianess here? __powerpc64__ is defined on > both big (aka ARCH=3Dpowerpc64) and little (aka ARCH=3Dpowerpc64le). Yes, powerpc64 has actually the same issue, but fixing it here causes segfa= ults (probably endianness-related) later on during build. --yotjpMnqJyoIoG2Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmIKRjcACgkQelmbhSCD nJ0PPBAAxJaT9KFkFUgk9OCiV5oiJ5SE5+qK+eTdjS6Xc/F53u+T0CkcJ/88DMeS 1crWRW+bhW+QHXfyYwK9JW8j86LTkUuiP996y4QTrBwpsB34qQIclD4lvVk0G3W/ kOBiBqZhfcRUgyagh9ZJu5uMjORFOfeOzZ/SjSzWOiitc7OPqZ4VVT4js/4pjCgz wrNnCLKk9YfnCK20VuPYpbAqV9RijSm/hHmXrXarQelXNtYNsUuBOrUOQgHanOSb 1Pr4ITa9xYhlHaiHgWOfV+5FoH8N05m9cmhfXo+LAPhQuluCgFhPIT1MRQB8MCWG ZOYMpKrkFdMTTPgJAzqioS62HtTBh6n5qNANrrm1hzXiEOXdS+/iQtXZ+VHMEBXp M/gV3elctwfj5k1u/kk3ZZ04wh9svJPu6iXGLzUudt+cf5Zi99K282o9YmZETBFh VVoI0YZwupASu2DRWqdPgGQrKiXYOgKwNz22xbnvVETiEJV1wFjR3U+B739UnWiP ujINS1I1ZH0enfTChgiuPR1ZnnRJMUEE6gSxpVZxN2PMwiLRV+n5u4gCvO9/LNnB yA8vlw3YVW0GkDvVFoppFs1qcAEDZ6byuQcA9/ooJ3+j8n2SFrkU2w3L4+oud9VH L+QYHwG0rHD1RUmZNRBZczkWFl5t3Gu4YyJPouJCs6knJ16+g8Y= =AhHf -----END PGP SIGNATURE----- --yotjpMnqJyoIoG2Y--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YgpGN7DrPLmvUWVm>