Date: Mon, 19 Sep 2005 17:54:18 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ed if_ed.c if_ed_pccard.c if_edvar.h Message-ID: <20050919145417.GE83017@ip.net.ua> In-Reply-To: <20050919.083111.123550990.imp@bsdimp.com> References: <200509182051.j8IKpYGU073493@repoman.freebsd.org> <20050919054051.GB65954@ip.net.ua> <20050919.083111.123550990.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--HeFlAV5LIbMFYYuh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 19, 2005 at 08:31:11AM -0600, M. Warner Losh wrote: > In message: <20050919054051.GB65954@ip.net.ua> > Ruslan Ermilov <ru@freebsd.org> writes: > : About the commonality... Usually foo_stop() (which is called first in > : foo_detach() if you were talking about the detach) disables interrupts, > : so foo_intr() doesn't usually happen. From reading the code, I see the > : same holds true for ed(4). >=20 > Wrong. Foo_intr() does still happen because other devices can > generate interrupts... >=20 Ah, you're right, I missed this bit. :-) > : OTOH, it was shown that on some SMP machines it's possible to get a > : call to foo_intr() after foo_stop() has been called by foo_shutdown(), > : which will lead to a panic in most of the drivers. See kern/85005 and > : kern/62889 for some examples. > :=20 > : I think the generic solution to this problem should be to return from > : foo_intr() quickly if IFF_DRV_RUNNING is not set. >=20 > Only if we free ifp after we tear down the interrupts. >=20 Yes. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --HeFlAV5LIbMFYYuh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDLtEZqRfpzJluFF4RAjeRAJ4vqJuPcSbggr1qoCTtrAPmponWpQCdFrlB GgLKIMqcqQldybssWmXiuD4= =7UWU -----END PGP SIGNATURE----- --HeFlAV5LIbMFYYuh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050919145417.GE83017>