Date: Mon, 7 Jul 2025 18:52:03 +0000 From: "markj (Mark Johnston)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-dtrace@freebsd.org Subject: [Differential] D51188: dtrace: fix symbol address resolving Message-ID: <543fe23f7359de7cb4e2e06865a70392@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-b4356atzpi5p55s5zcd7-req@reviews.freebsd.org>
index | next in thread | previous in thread | raw e-mail
markj added a comment. In D51188#1168819 <https://reviews.freebsd.org/D51188#1168819>, @zldrobit_gmail.com wrote: > @markj I found that we should also delete `st_value = 0` in `dt_module_symsort32/64()`, otherwise `dmp->dm_aslen` would always be lesser than `dmp->dm_asrsv` by at least one. As a result, `dt_module_symsort32/64()` ignore the last element in `dmp->dm_asmap` and `dt_module_symaddr32/64()` wouldn't find it. I had to update the patch accordingly. Sorry for interrupting the test suite procedure. It would be nice to refactor this `ST_BIND != STB_LOCAL || sym->st_size != 0` check into a helper function, but this should be done in a separate patch. REPOSITORY rG FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D51188/new/ REVISION DETAIL https://reviews.freebsd.org/D51188 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: zldrobit_gmail.com, #dtrace, gnn, markj Cc: markj, avg, freebsd-dtrace-list, imp, me_reviews.freebsd_lelf.lu, kpraveen.lkml_gmail.com, bkidney_briankidney.ca, dnelson_1901_yahoo.com, yan.jurak_gmail.com, bcr, lwhsu, jonathan, pstefhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?543fe23f7359de7cb4e2e06865a70392>