Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 May 2000 10:36:51 -0500
From:      Mike Pritchard <mpp@mppsystems.com>
To:        Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc:        Mike Pritchard <mpp@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/lpr/runqueue extern.h lpdchar.c modes.c printjob.c
Message-ID:  <20000524103651.A17012@mppsystems.com>
In-Reply-To: <200005241453.KAA60330@khavrinen.lcs.mit.edu>; from wollman@khavrinen.lcs.mit.edu on Wed, May 24, 2000 at 10:53:53AM -0400
References:  <200005241305.GAA88947@freefall.freebsd.org> <200005241453.KAA60330@khavrinen.lcs.mit.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 24, 2000 at 10:53:53AM -0400, Garrett Wollman wrote:
> <<On Wed, 24 May 2000 06:05:50 -0700 (PDT), Mike Pritchard <mpp@FreeBSD.org> said:
> 
> >   Remove the lpr/runqueue directory and associated files.
> >   These are not used anymore and are outdated and only cause
> >   confusion (I just committed a fix to one of these files within
> >   the last hour, thinking it was still valid).
> 
> Gee, thanks, you might have actually asked.....

I don't see a MAINTAINER line in the Makefile.

The last update to any of the files in that directory was the end of 1997
(the last rev date was 1997/12/02, other than $Id$ changes).
Who should I have asked?

Sorry if I caused a problem.  Have our cvs people resurect the directory
if you are still planning on continuing this work.  I diffed everything
first, and the current versions in the other directories looked like they
were more maintained, and I saw no changes in the runqueue directory
that should be brought over to the maintained versions.

In fact, all of the files were nearly identical to the other sources.
The most noticeable differences were the addition of locale support
in the sources that are actually in use.  And those changes were
pretty minimal.  

Just adding the directory and copying the current files in question
would leave them pretty much at the same point they were left 
at 2+ years ago.

When I decided to remove the directory, I first tried to determine if 
I could combine the various files into one "common" file, because I
was changing printjob.c, which was common to 2 directories, and I
thought I saw a lot of overlap.  Then I found out that everything in 
lpr/runqueue wasn't even used/compiled, so I nuked it.

-Mike
-- 
Mike Pritchard
mpp@FreeBSD.org or mpp@mppsystems.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000524103651.A17012>