Date: Fri, 20 Oct 2006 16:57:35 -0700 From: Sam Leffler <sam@errno.com> To: Julian Elischer <julian@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw_pfil.c ip_input.c Message-ID: <4539626F.3080003@errno.com> In-Reply-To: <4539616C.90901@errno.com> References: <200610201932.k9KJW8gF024621@repoman.freebsd.org> <4539616C.90901@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sam Leffler wrote: > Julian Elischer wrote: >> julian 2006-10-20 19:32:08 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet ip_fw_pfil.c ip_input.c >> Log: >> Move some variables to a more likely place >> and remove "temporary" stuff that is not needed any more. >> >> Revision Changes Path >> 1.22 +8 -0 src/sys/netinet/ip_fw_pfil.c >> http://cvsweb.FreeBSD.org/src/sys/netinet/ip_fw_pfil.c.diff?r1=1.21&r2=1.22 >> 1.321 +0 -12 src/sys/netinet/ip_input.c >> http://cvsweb.FreeBSD.org/src/sys/netinet/ip_input.c.diff?r1=1.320&r2=1.321 >> >> > This change breaks kernels w/o PFIL_HOOKS. I misspoke. It requires ipfw or similar to build: if_ethersubr.o(.text+0x828): In function `ether_output_frame': /usr/sam/avila/sys/net/if_ethersubr.c:386: undefined reference to `ip_fw_chk_ptr' if_ethersubr.o(.text+0xb20): In function `ether_ipfw_chk': /usr/sam/avila/sys/net/if_ethersubr.c:481: undefined reference to `fw_one_pass' if_ethersubr.o(.text+0xb28):/usr/sam/avila/sys/net/if_ethersubr.c:481: undefined reference to `ip_fw_chk_ptr' if_ethersubr.o(.text+0xb2c):/usr/sam/avila/sys/net/if_ethersubr.c:481: undefined reference to `ip_dn_io_ptr' if_ethersubr.o(.text+0x1274): In function `ether_demux': /usr/sam/avila/sys/net/if_ethersubr.c:830: undefined reference to `ip_fw_chk_ptr That's because you moved the variable out of the ip code and into ipfw. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4539626F.3080003>