Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 07 Aug 2003 11:18:02 -0300
From:      "Daniel C. Sobral" <dcs@tcoip.com.br>
To:        Nate Lawson <njl@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/contrib/dev/acpica acfreebsd.h
Message-ID:  <3F325F9A.8020906@tcoip.com.br>
In-Reply-To: <200308070446.h774kHAq037869@repoman.freebsd.org>
References:  <200308070446.h774kHAq037869@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson wrote:
> njl         2003/08/06 21:46:17 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/contrib/dev/acpica acfreebsd.h 
>   Log:
>   Add includes to fix user-compilation of acpica.  Also clarify a comment
>   about overriding the OS name.

This commit broke world on loader.

The problem is sys/boot/i386/libi386/biosacpi.c, which includes this 
file since your rev 1.5 commit. :-)

Specifically, stand.h, which is included by anything that uses libstand 
functions (such as is the case with biosacpi.c), is mutually exclusive 
with ctype.h.

Specifically:

/* Not building kernel code, so use libc */

is false on both accounts for loader. :-) Loader is not kernel, alright, 
but neither does it use libc.

Since I'm not familiar with how, exactly, is acfreebsd.h used, I can't 
offer more advise. :-)

Tricky, eh? :-)

Shouldn't ctype.h be a required include to anything including acfreebsd.h?

-- 
Daniel C. Sobral                   (8-DCS)
Gerencia de Operacoes
Divisao de Comunicacao de Dados
Coordenacao de Seguranca
VIVO Centro Oeste Norte
Fones: 55-61-313-7654/Cel: 55-61-9618-0904
E-mail: Daniel.Capo@tco.net.br
         Daniel.Sobral@tcoip.com.br
         dcs@tcoip.com.br

Outros:
	dcs@newsguy.com
	dcs@freebsd.org
	capo@notorious.bsdconspiracy.net

Old mail has arrived.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3F325F9A.8020906>