Date: Mon, 03 Sep 2001 10:18:35 -0700 From: Dima Dorfman <dima@unixfreak.org> To: hackers@freebsd.org Subject: Outdated comment in namei.h Message-ID: <20010903171840.DEE713E31@bazooka.unixfreak.org>
next in thread | raw e-mail | index | archive | help
The following is from namei.h, around line 116 in -current (r1.30): /* * Namei parameter descriptors. * * SAVENAME may be set by either the callers of namei or by VOP_LOOKUP. * If the caller of namei sets the flag (for example execve wants to * know the name of the program that is being executed), then it must * free the buffer. If VOP_LOOKUP sets the flag, then the buffer must >>>> * be freed by either the commit routine or the VOP_ABORT routine. * SAVESTART is set only by the callers of namei. It implies SAVENAME * plus the addition of saving the parent directory that contains the * name in ni_startdir. It allows repeated calls to lookup for the * name being sought. The caller is responsible for releasing the * buffer and for vrele'ing ni_startdir. */ The line marked refers to VOP_ABORT, which doesn't exist. It probably means VOP_ABORTOP, but that was removed two years ago. Anybody care to update this comment, or suggest what to write instead of that sentence? Would s/VOP_ABORT/NDFREE/ do it? Thanks. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010903171840.DEE713E31>