Date: Tue, 21 Mar 2017 01:42:44 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Hans Petter Selasky <hselasky@FreeBSD.org> Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt Message-ID: <0D2EB76A-146A-4679-8C56-2A84AFFE1822@gmail.com> In-Reply-To: <201703210639.v2L6dnRf055522@repo.freebsd.org> References: <201703210639.v2L6dnRf055522@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_29E8B198-32AF-47C9-94FF-0141A077604F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Mar 20, 2017, at 23:39, Gleb Smirnoff <glebius@freebsd.org> wrote: >=20 > Author: glebius > Date: Tue Mar 21 06:39:49 2017 > New Revision: 315662 > URL: https://svnweb.freebsd.org/changeset/base/315662 >=20 > Log: > Hide struct inpcb, struct tcpcb from the userland. >=20 > This is a painful change, but it is needed. On the one hand, we = avoid > modifying them, and this slows down some ideas, on the other hand we = still > eventually modify them and tools like netstat(1) never work on next = version of > FreeBSD. We maintain a ton of spares in them, and we already got = some ifdef > hell at the end of tcpcb. >=20 > Details: > - Hide struct inpcb, struct tcpcb under _KERNEL || _WANT_FOO. > - Make struct xinpcb, struct xtcpcb pure API structures, not = including > kernel structures inpcb and tcpcb inside. Export into these = structures > the fields from inpcb and tcpcb that are known to be used, and put = there > a ton of spare space. > - Make kernel and userland utilities compilable after these changes. > - Bump __FreeBSD_version. >=20 > Reviewed by: rrs, gnn > Differential Revision: D10018 This change broke the sdp module: = https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/2294/console . Thanks, -Ngie --Apple-Mail=_29E8B198-32AF-47C9-94FF-0141A077604F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY0OeEAAoJEPWDqSZpMIYVOIAP/0G8/IDlCF/2vEK1lEUwlHES +aeOt0EOJwgwOJBZ0AyEYclZ779j/ES7tSHQh/z0xeNZzwtjw+K5kj+/FDZglE34 eFQOiI2WZZZqI8+1nf1YjZOmFg4u6gZpX1EWQL0g92/acIpy02GEVoj7pcy+luZm 0XIuWY91RNZVT60XdpYVPPSCP55G6IbmI3aFZxt6wCWauruVq+OtDwpmWs9T/3Ec OVKe4wY4FfDKB3t2JZEDxR/Tqbi2oMGjh3eFcD5XN4XgQWin6Dqipk6btpsIbsAo iLn1eYGLLTEMB96pl/bhAbwN74CCRE5K84BIaVm+cxPWQ5FXrpIhENxausOZgxhY hBUvXjlT+usUJy75jC4KAx5vlvR0BxaicwOCgl75QE2fI8LY9BmFKJ4BmnKgrZ9n J4RrtfqnmwRUi36rijDpCMiBuq7jNioTDQ2gcpqsu3COhc/hGNhx0zRymOq0XnMp boDvdyFG1CtYfJ3D/gMTYt8Sfbvw8sA60REZz1E6MVfZL+5dNwX/JJ/r/JE6DcfC 2GpcicXSPW6O9IWpaXSPweL8lTnqH0d+NJ7W/vki6uFHrwa4DASL+9MMNP3AKm2z IaANMGKrkPoA9S4x52VhutJwolRif/XTnlwXIHskmvUGjpwouKlsyZ3zQHn7NdFH SiG6wtezclpJFCqvoBm4 =76pq -----END PGP SIGNATURE----- --Apple-Mail=_29E8B198-32AF-47C9-94FF-0141A077604F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0D2EB76A-146A-4679-8C56-2A84AFFE1822>