Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jul 2015 08:27:53 +0000
From:      "wma_semihalf.com (Wojciech Macek)" <phabric-noreply@FreeBSD.org>
To:        freebsd-arm@freebsd.org
Subject:   [Differential] [Updated, 4 lines] D3107: Fix ARM64 stack calculation
Message-ID:  <43e868f9bb9f06945472091bef791ab3@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-zqfyj4rhtcu6emsue7ys-req@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
wma_semihalf.com updated this revision to Diff 7002.

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST UPDATE
  https://reviews.freebsd.org/D3107?vs=7001&id=7002

REVISION DETAIL
  https://reviews.freebsd.org/D3107

AFFECTED FILES
  sys/arm64/arm64/locore.S

CHANGE DETAILS
  diff --git a/sys/arm64/arm64/locore.S b/sys/arm64/arm64/locore.S
  --- a/sys/arm64/arm64/locore.S
  +++ b/sys/arm64/arm64/locore.S
  @@ -27,6 +27,7 @@
    */
   
   #include "assym.s"
  +#include "opt_kstack_pages.h"
   
   #include <sys/syscall.h>
   #include <machine/asm.h>
  @@ -181,8 +182,7 @@
   mp_virtdone:
   	ldr	x4, =secondary_stacks
   	mov	x5, #(PAGE_SIZE * KSTACK_PAGES)
  -	sub	x1, x0, #1
  -	mul	x5, x1, x5
  +	mul	x5, x0, x5
   	add	sp, x4, x5
   
   	b	init_secondary

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: wma_semihalf.com, andoriyu_gmail.com, emaste, zbb
Cc: imp, andrew, freebsd-arm-list, emaste

[-- Attachment #2 --]
diff --git a/sys/arm64/arm64/locore.S b/sys/arm64/arm64/locore.S
--- a/sys/arm64/arm64/locore.S
+++ b/sys/arm64/arm64/locore.S
@@ -27,6 +27,7 @@
  */
 
 #include "assym.s"
+#include "opt_kstack_pages.h"
 
 #include <sys/syscall.h>
 #include <machine/asm.h>
@@ -181,8 +182,7 @@
 mp_virtdone:
 	ldr	x4, =secondary_stacks
 	mov	x5, #(PAGE_SIZE * KSTACK_PAGES)
-	sub	x1, x0, #1
-	mul	x5, x1, x5
+	mul	x5, x0, x5
 	add	sp, x4, x5
 
 	b	init_secondary

help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43e868f9bb9f06945472091bef791ab3>