Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 May 2016 13:58:55 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        geom@freebsd.org, "freebsd-arch@freebsd.org" <arch@freebsd.org>
Subject:   Re: Removing Giant asserts from geom
Message-ID:  <CANCZdfrNtx_hoFUdtTXYTPkW5hb=-xWK-cfNnnwJzN2wMUOo%2BA@mail.gmail.com>
In-Reply-To: <20160519105634.GO89104@kib.kiev.ua>
References:  <20160519105634.GO89104@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 19, 2016 at 4:56 AM, Konstantin Belousov
<kostikbel@gmail.com> wrote:
> I propose to remove asserts
>                 mtx_assert(&Giant, MA_NOTOWNED);
> from the geom KPI.

I can't see any reason for the assertion in today's kernel.

I might split out the lock / unlock of giant around thread creation
since that's different.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrNtx_hoFUdtTXYTPkW5hb=-xWK-cfNnnwJzN2wMUOo%2BA>