Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Jan 2011 12:51:56 GMT
From:      Edward Tomasz Napierala <trasz@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 188309 for review
Message-ID:  <201101291251.p0TCpuRp017212@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help

http://p4web.freebsd.org/@@188309?ac=10

Change 188309 by trasz@trasz_victim on 2011/01/29 12:51:10

	We don't need PROC_LOCK() just to check for P_SYSTEM.

Affected files ...

.. //depot/projects/soc2009/trasz_limits/sys/kern/kern_container.c#68 edit

Differences ...

==== //depot/projects/soc2009/trasz_limits/sys/kern/kern_container.c#68 (text+ko) ====

@@ -834,15 +834,13 @@
 		    NULL);
 
 		FOREACH_PROC_IN_SYSTEM(p) {
+			if (p->p_flag & P_SYSTEM)
+				continue;
+
 			microuptime(&wallclock);
 			timevalsub(&wallclock, &p->p_stats->p_start);
 			pctcpu_limit = rusage_get_available(p, RUSAGE_PCTCPU);
 			PROC_LOCK(p);
-			if (p->p_flag & P_SYSTEM) {
-				PROC_UNLOCK(p);
-				continue;
-			}
-
 			PROC_SLOCK(p);
 			FOREACH_THREAD_IN_PROC(p, td) {
 				ruxagg(p, td);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101291251.p0TCpuRp017212>