Date: Tue, 13 Nov 2012 08:01:29 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Ben Kaduk <minimarmot@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r242934 - head/sys/dev/xen/netback Message-ID: <50A1F049.3070800@FreeBSD.org> In-Reply-To: <CAK2BMK5c8wb9dSostjsjUHZOXGUG1KiWE1xHQi5sHtJMRMaSEQ@mail.gmail.com> References: <201211122228.qACMSWbs020517@svn.freebsd.org> <CAK2BMK5c8wb9dSostjsjUHZOXGUG1KiWE1xHQi5sHtJMRMaSEQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-11-12 23:57, Ben Kaduk wrote:> On Mon, Nov 12, 2012 at 5:28 PM, Dimitry Andric <dim@freebsd.org> wrote: >> Author: dim >> Date: Mon Nov 12 22:28:32 2012 >> New Revision: 242934 >> URL: http://svnweb.freebsd.org/changeset/base/242934 >> >> Log: >> Redo r242889, now using the method from projects/amd64_xen_pv r240747. >> >> Reminded by: kib >> MFC after: 3 days >> >> Modified: >> head/sys/dev/xen/netback/netback_unit_tests.c >> >> Modified: head/sys/dev/xen/netback/netback_unit_tests.c >> ============================================================================== >> --- head/sys/dev/xen/netback/netback_unit_tests.c Mon Nov 12 22:01:29 2012 (r242933) >> +++ head/sys/dev/xen/netback/netback_unit_tests.c Mon Nov 12 22:28:32 2012 (r242934) >> @@ -58,11 +58,11 @@ __FBSDID("$FreeBSD$"); >> #define TOSTRING(x) STRINGIFY(x) >> >> /** >> - * Writes an error message to buffer if cond is false, and returns true >> - * iff the assertion failed. Note the implied parameters buffer and >> + * Writes an error message to buffer if cond is false >> + * Note the implied parameters buffer and > > At risk of being Bruce, aren't comments like this supposed to be > complete sentences and end with a full stop? Yes, but I purposely copied what was in the projects/amd64_xen_pv branch, to make it easier for those people to merge back. Please take up comment comments with them, thanks. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50A1F049.3070800>