Date: Tue, 29 May 2018 14:39:08 -0500 From: Eric van Gyzen <eric@vangyzen.net> To: Matt Macy <mmacy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334347 - head/lib/libpmc Message-ID: <57a10ac9-f190-3bb7-0fec-8d43a8827455@vangyzen.net> In-Reply-To: <201805291907.w4TJ70L9004416@repo.freebsd.org> References: <201805291907.w4TJ70L9004416@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/29/2018 14:07, Matt Macy wrote:
> if (pmc_pmu_pmcallocate(ctrname, &pmc_config) == 0) {
> - if (PMC_CALL(PMCALLOCATE, &pmc_config) < 0)
> - return (errno);
> - free(spec_copy);
> + if (PMC_CALL(PMCALLOCATE, &pmc_config) < 0) {
> + retval = errno;
> + goto out;
> + }
> *pmcid = pmc_config.pm_pmcid;
> - return (0);
> + goto out;
This now returns -1 on the successful path.
Feel free to start throwing things at me now. ;)
Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57a10ac9-f190-3bb7-0fec-8d43a8827455>