Date: Wed, 30 May 2012 04:08:30 +0000 (UTC) From: Eitan Adler <eadler@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r236289 - head/usr.sbin/lpr/lpr Message-ID: <201205300408.q4U48UVJ025019@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: eadler Date: Wed May 30 04:08:29 2012 New Revision: 236289 URL: http://svn.freebsd.org/changeset/base/236289 Log: Relax security permissions on '.seq' file creation - the strict, but odd permissions resulted in a security alert from 110.neggrpperm PR: kern/165533 Submitted by: Anton Shterenlikht <mexas@bristol.ac.uk> Submitted by: J B <jb.1234abcd@gmail.com> Approved by: cperciva MFC after: 1 week Modified: head/usr.sbin/lpr/lpr/lpr.c Modified: head/usr.sbin/lpr/lpr/lpr.c ============================================================================== --- head/usr.sbin/lpr/lpr/lpr.c Wed May 30 04:06:38 2012 (r236288) +++ head/usr.sbin/lpr/lpr/lpr.c Wed May 30 04:08:29 2012 (r236289) @@ -846,7 +846,7 @@ mktemps(const struct printer *pp) (void) snprintf(buf, sizeof(buf), "%s/.seq", pp->spool_dir); seteuid(euid); - if ((fd = open(buf, O_RDWR|O_CREAT, 0661)) < 0) { + if ((fd = open(buf, O_RDWR|O_CREAT, 0664)) < 0) { printf("%s: cannot create %s\n", progname, buf); exit(1); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205300408.q4U48UVJ025019>