Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Mar 2026 19:10:51 +0000
From:      Andrew Turner <andrew@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 522012c8bd07 - main - Revert "virtio: Restore mb() calls"
Message-ID:  <69b06cbb.24fe2.5c550203@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by andrew:

URL: https://cgit.FreeBSD.org/src/commit/?id=522012c8bd079879b82aaa403e4da3c1ab9fc8a9

commit 522012c8bd079879b82aaa403e4da3c1ab9fc8a9
Author:     Andrew Turner <andrew@FreeBSD.org>
AuthorDate: 2026-03-10 19:09:41 +0000
Commit:     Andrew Turner <andrew@FreeBSD.org>
CommitDate: 2026-03-10 19:09:41 +0000

    Revert "virtio: Restore mb() calls"
    
    This reverts commit d99e725c26a7745aa349eab01ae56ca630b6d0f5.
---
 sys/dev/virtio/virtqueue.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/sys/dev/virtio/virtqueue.c b/sys/dev/virtio/virtqueue.c
index b7fdb4703ccb..dbd55e02e091 100644
--- a/sys/dev/virtio/virtqueue.c
+++ b/sys/dev/virtio/virtqueue.c
@@ -565,9 +565,6 @@ virtqueue_notify(struct virtqueue *vq)
 	/* Ensure updated avail->idx is visible to host. */
 	bus_dmamap_sync(vq->vq_ring_dmat, vq->vq_ring_mapp,
 	    BUS_DMASYNC_PREWRITE);
-#if defined(__i386__) || defined(__amd64__)
-	mb();
-#endif
 
 	if (vq_ring_must_notify_host(vq))
 		vq_ring_notify_host(vq);
@@ -963,9 +960,6 @@ vq_ring_enable_interrupt(struct virtqueue *vq, uint16_t ndesc)
 
 	bus_dmamap_sync(vq->vq_ring_dmat, vq->vq_ring_mapp,
 	    BUS_DMASYNC_PREWRITE);
-#if defined(__i386__) || defined(__amd64__)
-	mb();
-#endif
 
 	/*
 	 * Enough items may have already been consumed to meet our threshold


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69b06cbb.24fe2.5c550203>