Date: Mon, 1 Sep 2003 16:21:22 -0400 (EDT) From: Daniel Eischen <eischen@vigrid.com> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gcc/config freebsd-spec.h Message-ID: <Pine.GSO.4.10.10309011615060.14985-200000@pcnet5.pcnet.com> In-Reply-To: <20030901160817.GA64187@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.
---559023410-851401618-1062447682=:14985
Content-Type: TEXT/PLAIN; charset=US-ASCII
On Mon, 1 Sep 2003, David O'Brien wrote:
> On Mon, Sep 01, 2003 at 02:08:58AM -0400, Daniel Eischen wrote:
> > > > > Please back this out.
>
> Thank you for backing this out.
... just playing by the rules :-)
> > > For one, don't forget people use the GCC ports and the stock sources from
> > > the FSF -- we don't need the system compiler to be the old man out. If
> > > you really want to de-support "-pthread" there are two ways to go about
> > > it. (1) starting with some GCC version, (2) starting with targeting a
> > > particular FreeBSD version. For instance we could either say that GCC
> > > 3.4 does not accept "-pthread" for any FreeBSD target. Or we could say
> > > that GCC targeting RELENG_5 does not accept "-pthread". It should be
> > > clear which is being chosen and the repercussions.
> >
> > RELENG_5 should not support it. We need to get rid of
> > it ASAP so we can work on getting our ports free of it
> > and making them work with other thread libraries.
> >
> > How do we accomplish this quickly?
>
> Sounds like you want a policy that:
>
> "-pthread" should not be supported when targeting FreeBSD 5.{2-9}
> using FSF GCC 3.3.2 (and 3.3.1 in /usr/src).
Sounds right.
> You would also like to not support "-pthread" when targeting FreeBSD 4.x.
> I'm not convinced that we really can remove it there. Also that will
> make FSF GCC 3.3.2 not accept the same options that the system FreeBSD
> 4.x compiler does. Can we live with tolerating "-pthread" when targeting
> FreeBSD 4.x by any version of FSF GCC?
Hmm, you mean cross-compiling. I guess, if you're cross-compiling
and still need to provide -pthread-like behavior, you can still do
it with -nostdlib -lc_r etc.
> If so, an acceptable diff would be to only change the FBSD_LIB_SPEC w/in
> the "#if __FreeBSD_version >= 500016" block. Turning "-pthread" into a
> NOP + warning would be nice, but the error output code you replaced the
> entire FBSD_LIB_SPEC with would be OK too I guess. The comment
> addressing "At __FreeBSD_version 500016 and later,..." should be updated.
> Can you commit such a change? I'll get it into the right FSF GCC
> person's hands for GCC 3.3.2.
Yes, see attached patch for review. I'll won't commit it until you've
reviewed it.
Thanks for taking the time to work with me on this.
--
Dan Eischen
---559023410-851401618-1062447682=:14985
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="gcc.diffs"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.GSO.4.10.10309011621220.14985@pcnet5.pcnet.com>
Content-Description: Removing -pthread
Content-Disposition: attachment; filename="gcc.diffs"
SW5kZXg6IGNvbmZpZy5nY2MNCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJD
UyBmaWxlOiAvb3B0L0ZyZWVCU0QvY3ZzL3NyYy9jb250cmliL2djYy9jb25m
aWcuZ2NjLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xLjEuNw0KZGlmZiAt
dSAtcjEuMS4xLjcgY29uZmlnLmdjYw0KLS0tIGNvbmZpZy5nY2MJMTEgSnVs
IDIwMDMgMDM6NDA6NDggLTAwMDAJMS4xLjEuNw0KKysrIGNvbmZpZy5nY2MJ
MjggQXVnIDIwMDMgMTY6NTA6MjkgLTAwMDANCkBAIC00ODQsMTEgKzQ4NCwx
MSBAQA0KIAl4bm8pIGZic2RfdG1fZmlsZT0iJHtmYnNkX3RtX2ZpbGV9IGZy
ZWVic2QtbnRoci5oIjs7DQogCXggfCB4eWVzIHwgeHB0aHJlYWRzIHwgeHBv
c2l4KQ0KIAkJdGhyZWFkX2ZpbGU9J3Bvc2l4Jw0KLQkJdG1ha2VfZmlsZT0i
JHt0bWFrZV9maWxlfSB0LWZyZWVic2QtdGhyZWFkIg0KIAkJIyBCZWZvcmUg
NS4wLCBGcmVlQlNEIGNhbid0IGJpbmQgc2hhcmVkIGxpYnJhcmllcyB0byAt
bGMNCiAJCSMgd2hlbiAib3B0aW9uYWxseSIgdGhyZWFkZWQgdmlhIHdlYWsg
cHRocmVhZF8qIGNoZWNrcy4NCiAJCWNhc2UgJG1hY2hpbmUgaW4NCiAJCSot
Ki1mcmVlYnNkWzM0XSB8ICotKi1mcmVlYnNkWzM0XS4qKQ0KKwkJCXRtYWtl
X2ZpbGU9IiR7dG1ha2VfZmlsZX0gdC1mcmVlYnNkLXRocmVhZCINCiAJCQl0
bWFrZV9maWxlPSIke3RtYWtlX2ZpbGV9IHQtc2xpYmdjYy1ub2xjLW92ZXJy
aWRlIjs7DQogCQllc2FjDQogCQk7Ow0KSW5kZXg6IGNvbmZpZy9mcmVlYnNk
LXNwZWMuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9v
cHQvRnJlZUJTRC9jdnMvc3JjL2NvbnRyaWIvZ2NjL2NvbmZpZy9mcmVlYnNk
LXNwZWMuaCx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTENCmRpZmYgLXUg
LXIxLjExIGZyZWVic2Qtc3BlYy5oDQotLS0gY29uZmlnL2ZyZWVic2Qtc3Bl
Yy5oCTEgU2VwIDIwMDMgMDU6MzE6MzMgLTAwMDAJMS4xMQ0KKysrIGNvbmZp
Zy9mcmVlYnNkLXNwZWMuaAkxIFNlcCAyMDAzIDE5OjQ1OjIxIC0wMDAwDQpA
QCAtMTMxLDE1ICsxMzEsMTcgQEANCiAgICByZXF1aXJlZCBieSB0aGUgdXNl
ci1sYW5kIHRocmVhZCBtb2RlbC4gIEJlZm9yZSBfX0ZyZWVCU0RfdmVyc2lv
bg0KICAgIDUwMDAxNiwgc2VsZWN0IHRoZSBhcHByb3ByaWF0ZSBsaWJjLCBk
ZXBlbmRpbmcgb24gd2hldGhlciB3ZSdyZQ0KICAgIGRvaW5nIHByb2ZpbGlu
ZyBvciBuZWVkIHRocmVhZHMgc3VwcG9ydC4gIEF0IF9fRnJlZUJTRF92ZXJz
aW9uDQotICAgNTAwMDE2IGFuZCBsYXRlciwgd2hlbiB0aHJlYWRzIHN1cHBv
cnQgaXMgcmVxdWVzdGVkIGluY2x1ZGUgYm90aA0KLSAgIC1sYyBhbmQgLWxj
X3IgaW5zdGVhZCBvZiBvbmx5IC1sY19yLiAgVG8gbWFrZSBtYXR0ZXJzIGlu
dGVyZXN0aW5nLA0KLSAgIHdlIGNhbid0IGFjdHVhbGx5IHVzZSBfX0ZyZWVC
U0RfdmVyc2lvbiBwcm92aWRlZCBieSA8b3NyZWxkYXRlLmg+DQotICAgZGly
ZWN0bHkgc2luY2UgaXQgYnJlYWtzIGNyb3NzLWNvbXBpbGluZy4gIEFzIGEg
ZmluYWwgdHdpc3QsIG1ha2UNCi0gICBpdCBhIGhhcmQgZXJyb3IgaWYgLXB0
aHJlYWQgaXMgcHJvdmlkZWQgb24gdGhlIGNvbW1hbmQgbGluZSBhbmQgZ2Nj
DQotICAgd2FzIGNvbmZpZ3VyZWQgd2l0aCAtLWRpc2FibGUtdGhyZWFkcyAo
dGhpcyB3aWxsIGhlbHAgYXZvaWQgYnVnDQotICAgcmVwb3J0cyBmcm9tIHVz
ZXJzIGNvbXBsYWluaW5nIGFib3V0IHRocmVhZGluZyB3aGVuIHRoZXkNCi0g
ICBtaXNjb25maWd1cmVkIHRoZSBnY2MgYm9vdHN0cmFwIGJ1dCBhcmUgbGF0
ZXIgY29uc3VsdGluZyBGcmVlQlNEDQotICAgbWFudWFsIHBhZ2VzIHRoYXQg
cmVmZXIgdG8gdGhlIG15dGhpY2FsIC1wdGhyZWFkIG9wdGlvbikuICAqLw0K
KyAgIDUwMDAxNiBhbmQgbGF0ZXIsIHRocmVhZHMgbGlicmFyaWVzIGNhbiBi
ZSBsaW5rZWQgd2l0aCBsaWJjLg0KKyAgIEJlY2F1c2Ugb2YgdGhpcywgYW5k
IGJlY2F1c2UgZGlmZmVyZW50IChub3QgbXVsdGlwbGUpIHRocmVhZGluZw0K
KyAgIGxpYnJhcmllcyBtYXkgYmUgc2VsZWN0ZWQgaW4gdGhlIGxpbmsgb3B0
aW9uLCB0aGUgLXB0aHJlYWQgb3B0aW9uDQorICAgaXMgbm8gbG9uZ2VyIHN1
cHBvcnRlZC4gIFRvIG1ha2UgbWF0dGVycyBpbnRlcmVzdGluZywgd2UgY2Fu
J3QNCisgICBhY3R1YWxseSB1c2UgX19GcmVlQlNEX3ZlcnNpb24gcHJvdmlk
ZWQgYnkgPG9zcmVsZGF0ZS5oPiBkaXJlY3RseQ0KKyAgIHNpbmNlIGl0IGJy
ZWFrcyBjcm9zcy1jb21waWxpbmcuICBBcyBhIGZpbmFsIHR3aXN0LCBtYWtl
IGl0IGEgaGFyZA0KKyAgIGVycm9yIGlmIC1wdGhyZWFkIGlzIHByb3ZpZGVk
IG9uIHRoZSBjb21tYW5kIGxpbmUgYW5kIGdjYyB3YXMNCisgICBjb25maWd1
cmVkIHdpdGggLS1kaXNhYmxlLXRocmVhZHMgKHRoaXMgd2lsbCBoZWxwIGF2
b2lkIGJ1ZyByZXBvcnRzDQorICAgZnJvbSB1c2VycyBjb21wbGFpbmluZyBh
Ym91dCB0aHJlYWRpbmcgd2hlbiB0aGV5IG1pc2NvbmZpZ3VyZWQgdGhlDQor
ICAgZ2NjIGJvb3RzdHJhcCBidXQgYXJlIGxhdGVyIGNvbnN1bHRpbmcgRnJl
ZUJTRCBtYW51YWwgcGFnZXMgdGhhdA0KKyAgIHJlZmVyIHRvIHRoZSBteXRo
aWNhbCAtcHRocmVhZCBvcHRpb24pLiAgKi8NCiANCiAvKiBQcm92aWRlIGEg
TElCX1NQRUMgYXBwcm9wcmlhdGUgZm9yIEZyZWVCU0QuICBKdXN0IHNlbGVj
dCB0aGUgYXBwcm9wcmlhdGUNCiAgICBsaWJjLCBkZXBlbmRpbmcgb24gd2hl
dGhlciB3ZSdyZSBkb2luZyBwcm9maWxpbmcgb3IgbmVlZCB0aHJlYWRzIHN1
cHBvcnQuDQpAQCAtMTU3LDkgKzE1OSwxMCBAQA0KICNpbmNsdWRlIDxzeXMv
cGFyYW0uaD4NCiAjaWYgX19GcmVlQlNEX3ZlcnNpb24gPj0gNTAwMDE2DQog
I2RlZmluZSBGQlNEX0xJQl9TUEVDICIJCQkJCQkJXA0KKyAgJXtwdGhyZWFk
OiAlZVRoZSAtcHRocmVhZCBvcHRpb24gaXMgZGVwcmVjYXRlZC59CQkJXA0K
ICAgJXshc2hhcmVkOgkJCQkJCQkJXA0KLSAgICAleyFwZzogJXtwdGhyZWFk
Oi1sY19yfSAtbGN9CQkJCQlcDQotICAgICV7cGc6ICAle3B0aHJlYWQ6LWxj
X3JfcH0gLWxjX3B9CQkJCQlcDQorICAgICV7IXBnOiAtbGN9CQkJCQkJCQlc
DQorICAgICV7cGc6IC1sY19wfQkJCQkJCQlcDQogICB9Ig0KICNlbHNlDQog
I2RlZmluZSBGQlNEX0xJQl9TUEVDICIJCQkJCQkJXA0K
---559023410-851401618-1062447682=:14985--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.10.10309011615060.14985-200000>