Date: Sun, 13 Oct 2002 17:40:55 +0200 From: Stefan Farfeleder <e0026813@stud3.tuwien.ac.at> To: Dmitry Morozovsky <marck@rinet.ru> Cc: Kelly Yancey <kbyanc@FreeBSD.ORG>, stable@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_subr.c Message-ID: <20021013154055.GA265@frog.fafoe> In-Reply-To: <20021013192019.Y1640-100000@woozle.rinet.ru> References: <20021013191641.R1640-100000@woozle.rinet.ru> <20021013192019.Y1640-100000@woozle.rinet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 13, 2002 at 07:22:17PM +0400, Dmitry Morozovsky wrote:
> On Sun, 13 Oct 2002, Dmitry Morozovsky wrote:
>
> DM> On Sun, 13 Oct 2002, Kelly Yancey wrote:
> DM>
> DM> KY> kbyanc 2002/10/13 00:38:41 PDT
> DM> KY>
> DM> KY> Modified files: (Branch: RELENG_4)
> DM> KY> sys/kern vfs_subr.c
> DM> KY> Log:
> DM> KY> Use <sys/queue.h> macros rather than fondling implementation details.
> DM>
> DM> Kelly, it seems this commit broke -stable (see PR/44007)
>
> ... and I can confirm that backing out this change revert -stable to working
>
> (patch for band-aiding follows)
>
> Index: sys/kern/vfs_subr.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/kern/vfs_subr.c,v
> retrieving revision 1.249.2.28
> diff -u -r1.249.2.28 vfs_subr.c
> --- sys/kern/vfs_subr.c 13 Oct 2002 07:38:41 -0000 1.249.2.28
> +++ sys/kern/vfs_subr.c 13 Oct 2002 15:17:55 -0000
> @@ -1256,7 +1256,7 @@
> KASSERT(bp->b_vp != NULL, ("pbrelvp: NULL"));
>
> /* XXX REMOVE ME */
> - if (!TAILQ_NEXT(bp, b_vnbufs)) {
> + if (bp->b_vnbufs.tqe_next != NULL) {
> panic(
> "relpbuf(): b_vp was probably reassignbuf()d %p %x",
> bp,
>
>
The line should probably read:
if (TAILQ_NEXT(bp, b_vnbufs) != NULL) {
Regards,
Stefan Farfeleder
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021013154055.GA265>