Date: Tue, 17 Feb 1998 15:41:39 +0100 (MET) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: scrappy@FreeBSD.ORG (Marc G. Fournier) Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/include soundcard.h src/sys/i386/isa/snd Message-ID: <199802171441.PAA00598@labinfo.iet.unipi.it> In-Reply-To: <199802171417.GAA07742@freefall.freebsd.org> from "Marc G. Fournier" at Feb 17, 98 06:16:56 am
next in thread | previous in thread | raw e-mail | index | archive | help
> scrappy 1998/02/17 06:17:15 PST
>
> Modified files:
> sys/i386/include soundcard.h
> sys/i386/isa/snd README ad1848.c dmabuf.c sb_dsp.c
> sbcard.h sound.c sound.h soundcard.h
> Added files:
> sys/i386/isa/snd CARDS
> sys/i386/isa/snd/doc Makefile sound.ps.gz sound.tex
> sys/i386/isa/snd/misc README audio-voxware.cc auvoxware.c
> files.i386 linux.patch linux_a.c
> mmap_test.c pcmio.c soundbyte.c test.c
> Log:
> Upgrade Luigi's audio driver to Jan/23 version... will bring in Feb/15th
> version as soon as I've tested it...
sorry but this is not a very good move for the following reasons:
1) together with Nate and Jordan we have done some work to do a
proper merge of the code to minimize differences between -stable,
-current, my snapshot, and the common files (soundcard.h and ulaw.h)
and remove some of the confusion with audio driver.
The Jan23 code, although basically the same as Feb15, does not
contains all these little but significantly fixes;
and especially:
2) doc/ and misc/ DO NOT BELONG in the kernel source tree.
I put them there just to make life easier for those who download
the tarball from my side. But
a) the paper documenting the code should go in some directory
in /usr/share/doc/papers/;
b) some of the files in misc/ should be used by port maintainers
to fix the audio modules of the various apps involved;
some others (e.g. linux.patch) should be used to fix other parts
of the kernel, e.g. linux emulator;
finally, some of them are just sample applications or testing
tools which at most should go into /usr/bin (pcmio) or even left
alone.
So, although (I hope) you are working on -current, can you please
remove the doc/ and misc/ stuff at least, and ask Nate what goes into
-current (basically the same bits as in -stable, except a few lines of
diffs for select/poll and DEVFS)
cheers
luigi
-----------------------------+--------------------------------------
Luigi Rizzo | Dip. di Ingegneria dell'Informazione
email: luigi@iet.unipi.it | Universita' di Pisa
tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy)
fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/
_____________________________|______________________________________
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199802171441.PAA00598>