Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Jan 2010 19:40:42 -0800
From:      Jeremy Chadwick <freebsd@jdc.parodius.com>
To:        freebsd-stable@freebsd.org
Cc:        mav@freebsd.org
Subject:   Recent ahci.c commit breaks buildkernel (RELENG_8)
Message-ID:  <20100116034042.GA9916@icarus.home.lan>

next in thread | raw e-mail | index | archive | help
This most recent commit:

http://svn.freebsd.org/viewvc/base/stable/8/sys/dev/ahci/ahci.c?r1=201588&r2=202428
http://www.freebsd.org/cgi/getmsg.cgi?fetch=1059860+0+current/cvs-src-old
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/ahci/ahci.c#rev1.1.2.18

Has broken buildkernel.  I've verified this on two separate machines:

===> ahci (all)
cc -O2 -pipe -march=nocona -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/SG45H7_RELENG_8_amd64/opt_global.h -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -g -fno-omit-frame-pointer -I/usr/obj/usr/src/sys/SG45H7_RELENG_8_amd64 -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c /usr/src/sys/modules/ahci/../../dev/ahci/ahci.c
cc1: warnings being treated as errors
/usr/src/sys/modules/ahci/../../dev/ahci/ahci.c: In function 'ahci_setup_interrupt':
/usr/src/sys/modules/ahci/../../dev/ahci/ahci.c:574: warning: implicit declaration of function 'bus_describe_intr'
/usr/src/sys/modules/ahci/../../dev/ahci/ahci.c:574: warning: nested extern declaration of 'bus_describe_intr'
*** Error code 1

Stop in /usr/src/sys/modules/ahci.
*** Error code 1

Stop in /usr/src/sys/modules.
*** Error code 1

bus_describe_intr() doesn't appear to exist in RELENG_8.

# grep -r bus_describe_intr /usr/src
/usr/src/sys/dev/ahci/ahci.c:                   bus_describe_intr(dev, ctlr->irqs[i].r_irq,
#

-- 
| Jeremy Chadwick                                   jdc@parodius.com |
| Parodius Networking                       http://www.parodius.com/ |
| UNIX Systems Administrator                  Mountain View, CA, USA |
| Making life hard for others since 1977.              PGP: 4BD6C0CB |




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100116034042.GA9916>