Date: Sun, 17 Oct 2021 10:24:50 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Vin??cius Zavam <egypcio@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b1fe2ae52311 - main - net-mgmt/mk-livestatus: fix "ld: error: duplicate symbol: g_mainthread_id" Message-ID: <YWv58vsV4TEd3Dkz@FreeBSD.org> In-Reply-To: <202110170759.19H7xLet040280@gitrepo.freebsd.org> References: <202110170759.19H7xLet040280@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 17, 2021 at 07:59:21AM +0000, Vin??cius Zavam wrote: > commit b1fe2ae52311869265eb74a9940a1dd502bd1e74 > > net-mgmt/mk-livestatus: fix "ld: error: duplicate symbol: g_mainthread_id" > > - add '-fcommon' to our CFLAGS in order to build with clang 11; It's unclear from the commit log why forcing -fcommon had been preferred over fixing the code, which is what we usually do unless resulting patch becomes too big. Could you elaborate? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YWv58vsV4TEd3Dkz>