Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 04 Oct 2023 14:37:15 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 274198] ktrace: logs only one arg for symlink() call
Message-ID:  <bug-274198-227-FE5h6KEj3Y@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-274198-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-274198-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274198

--- Comment #5 from Mark Johnston <markj@FreeBSD.org> ---
(In reply to Dmitry Chagin from comment #4)
I am on the fence.  I agree it is weird to use NAMEI here, but as Ivan poin=
ted
out, ktrnamei() is already (ab)used by shm_copyin_path() and vn_getcwd().

But, the symlink target is not accessed by the kernel, and the symlink targ=
et
can be an arbitrary string, it does not have to be a path, see malloc.conf(=
5)
for example.  So NAMEI really isn't right.  I think KTR_STRING is probably a
better solution; I would extend the KTR_STRUCT flag to include strings.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-274198-227-FE5h6KEj3Y>