Date: Tue, 07 Jan 2025 14:30:24 +0000 From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 283142] rtw88: does not connect to network [was: Error when connecting to WiFi | Invalid argument in wpa_supplicant] Message-ID: <bug-283142-21060-gC1iXv3jUN@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-283142-21060@https.bugs.freebsd.org/bugzilla/> References: <bug-283142-21060@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283142 --- Comment #22 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D2372f8cc640c2f4ab82831e6ac0e27ab6= c18321a commit 2372f8cc640c2f4ab82831e6ac0e27ab6c18321a Author: Bjoern A. Zeeb <bz@FreeBSD.org> AuthorDate: 2024-12-20 14:23:50 +0000 Commit: Bjoern A. Zeeb <bz@FreeBSD.org> CommitDate: 2025-01-07 14:26:17 +0000 LinuxKPI 802.11 / rtw88: make packets flow again In 886653492945f we added checks for packets to only go out if the station is known to the firmware (amongst others) as there are implications in drivers. Unfortunately rtw88 does not support the mac80211 (*sta_state)() KPI but only the fallback (*sta_add/remove)() in which case the station is only added to firmware when going from AUTH to ASSOC. That means we had no chance to get authenticated anymore. The problem has existed since June in main and stable/14 but only now was noticed in December with 14.2-R which makes me wonder. I am still not entirely sure what implications the missing checks have on all the other drivers using (*sta_state)() (or if they were really needed in first place beyond txq_ready) but I have run a few days of iwlwifi with this without extra trouble but I was not always able to reproduce problems in the past. Also people are occasionally still reporting the original "Invalid TXQ" error which indicates there is another lingering case somewhere. For the moment make rtw88 work again and expose the change to a wider audience. PR: 283142, 274382 Fixes: 886653492945f (make sure we can send DISASSOC or DEAUTH frames) Tested by: imb protected-networks.net, oleg.nauman gmail.com Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D48161 sys/compat/linuxkpi/common/src/linux_80211.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-283142-21060-gC1iXv3jUN>