Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 May 2009 12:29:32 -0700
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        Rick Macklem <rmacklem@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r192463 - head/sys/fs/nfsserver
Message-ID:  <eaa228be0905201229m2fcd024t58c29206776e0a30@mail.gmail.com>
In-Reply-To: <200905201858.n4KIw7Fc040619@svn.freebsd.org>
References:  <200905201858.n4KIw7Fc040619@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
When client ids have been run out of, does that put something into a
dangerous state (insecure or crash-prone)?  Isn't it better to let the
administrator make the decision of when to reboot the machine?

On Wed, May 20, 2009 at 11:58 AM, Rick Macklem <rmacklem@freebsd.org> wrote=
:
> Author: rmacklem
> Date: Wed May 20 18:58:07 2009
> New Revision: 192463
> URL: http://svn.freebsd.org/changeset/base/192463
>
> Log:
> =A0Although it should never happen, all the nfsv4 server can do
> =A0when it runs out of clientids is reboot. I had replaced cpu_reboot()
> =A0with printf(), since cpu_reboot() doesn't exist for sparc64.
> =A0This change replaces the printf() with panic(), so the reboot
> =A0would occur for this highly unlikely occurrence.
>
> =A0Approved by: =A0kib (mentor)
>
> Modified:
> =A0head/sys/fs/nfsserver/nfs_nfsdstate.c
>
> Modified: head/sys/fs/nfsserver/nfs_nfsdstate.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/fs/nfsserver/nfs_nfsdstate.c =A0 =A0 =A0 Wed May 20 18:45:49=
 2009 =A0 =A0 =A0 =A0(r192462)
> +++ head/sys/fs/nfsserver/nfs_nfsdstate.c =A0 =A0 =A0 Wed May 20 18:58:07=
 2009 =A0 =A0 =A0 =A0(r192463)
> @@ -3709,7 +3709,7 @@ nfsrv_nextclientindex(void)
> =A0 =A0 =A0 =A0 * In practice, we'll never get here, but the reboot is he=
re,
> =A0 =A0 =A0 =A0 * just for fun. (client_index will not wrap around on any=
 real server)
> =A0 =A0 =A0 =A0 */
> - =A0 =A0 =A0 printf("you must reboot now\n");
> + =A0 =A0 =A0 panic("nfsv4 server out of clientids");
> =A0 =A0 =A0 =A0return (0); =A0 =A0 /* Just to shut the compiler up */
> =A0}
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?eaa228be0905201229m2fcd024t58c29206776e0a30>