Date: Fri, 12 Jan 2001 15:38:42 +0000 (GMT) From: Jan Grant <Jan.Grant@bristol.ac.uk> To: Soren Schmidt <sos@freebsd.dk> Cc: Jan Grant <Jan.Grant@bristol.ac.uk>, freebsd-bugs <freebsd-bugs@FreeBSD.ORG> Subject: Re: i386/24272: ATAPI CD open causes "ticks" on IDE drive Message-ID: <Pine.GSO.4.31.0101121536440.16552-100000@mail.ilrt.bris.ac.uk> In-Reply-To: <200101121519.QAA52661@freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 12 Jan 2001, Soren Schmidt wrote:
> It seems Jan Grant wrote:
> >
> > As I said, it really does sound like the hard drive head is "ticking";
> > there is a separate CD-rom activity light and both lights generally
> > only come on during activity of the appropriate device.
> >
> > Yes, the two devices _are_ on separate controllers. It may be that the
> > hardware causes both devices/controllers to jump on a tray-close; I'm
> > not a hardware expert.
>
> Hmm that patch shouldn't be able to do this, at any rate try this
> patch which removes the close-tray-on-open and is in the queue to
> be committed anyways:
>
> Index: atapi-cd.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/ata/atapi-cd.c,v
> retrieving revision 1.48.2.8
> diff -u -r1.48.2.8 atapi-cd.c
> --- atapi-cd.c 2001/01/07 16:55:20 1.48.2.8
> +++ atapi-cd.c 2001/01/12 15:17:54
> @@ -500,8 +500,6 @@
> if (!(cdp = dev->si_drv1))
> return ENXIO;
>
> - acd_eject(cdp, 1);
> -
> if (flags & FWRITE) {
> if (count_dev(dev) > 1)
> return EBUSY;
This works; I'd already taken out the change (not got around to
following up to gnats though).
It looks like both controllers get a ping whenever the CD tray is closed
- I think this is a M/B issue; the only reason it was showing up was
this line, however. Glad to hear it won't be sticking around.
Thanks for your help.
--
jan grant, ILRT, University of Bristol. http://www.ilrt.bris.ac.uk/
Tel +44(0)117 9287163 Fax +44 (0)117 9287112 RFC822 jan.grant@bris.ac.uk
Whose kung-fu is the best?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.31.0101121536440.16552-100000>