Date: Tue, 7 Nov 2017 15:01:38 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r325515 - head Message-ID: <201711071501.vA7F1c5H028127@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Tue Nov 7 15:01:38 2017 New Revision: 325515 URL: https://svnweb.freebsd.org/changeset/base/325515 Log: Note interactive shell errors for make buildenv and add a warning for people tempted to add back the || true to get rid of them. Sponsored by: Netflix Modified: head/Makefile.inc1 Modified: head/Makefile.inc1 ============================================================================== --- head/Makefile.inc1 Tue Nov 7 14:28:10 2017 (r325514) +++ head/Makefile.inc1 Tue Nov 7 15:01:38 2017 (r325515) @@ -988,6 +988,14 @@ buildenvvars: .PHONY .endif .endif BUILDENV_DIR?= ${.CURDIR} +# +# Note: make will report any errors the shell reports. This can +# be odd if the last command in an interactive shell generates an +# error or is terminated by SIGINT. These reported errors look bad, +# but are harmless. Allowing them also allows BUIDLENV_SHELL to +# be a complex command whose status will be returned to the caller. +# Some scripts in tools rely on this behavior to report build errors. +# buildenv: .PHONY @echo Entering world for ${TARGET_ARCH}:${TARGET} .if ${BUILDENV_SHELL:M*zsh*}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201711071501.vA7F1c5H028127>