Date: Tue, 15 Mar 2011 17:14:14 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219676 - head/sys/x86/x86 Message-ID: <201103151714.15829.jkim@FreeBSD.org> In-Reply-To: <201103151701.11708.jhb@freebsd.org> References: <201103151947.p2FJlK3L057573@svn.freebsd.org> <201103151701.11708.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 15 March 2011 05:01 pm, John Baldwin wrote: > On Tuesday, March 15, 2011 3:47:20 pm Jung-uk Kim wrote: > > Author: jkim > > Date: Tue Mar 15 19:47:20 2011 > > New Revision: 219676 > > URL: http://svn.freebsd.org/changeset/base/219676 > > > > Log: > > Do not let machdep.tsc_freq modify tsc_freq itself. It is bad > > for i386 as it does not operate atomically. Actually, it serves > > no purpose. > > > > Noticed by: bde > > Ouch, please revert! We have depended on this for testing to > workaround BIOS issues (e.g. the USB SMI# handler firing at a bad > time during boot causing the TSC frequency to be calculated > incorrectly). I agree it's a hack that this works, but it has > actually proven useful in the past. You can still change timecounter frequency. Can you please explain why you need to change tsc_freq directly? Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103151714.15829.jkim>